Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/windows-path-issue-tree-view #1179

Merged

Conversation

carlosallexandre
Copy link
Contributor

Motivation

This PR addresses a bug where globSync fails on Windows due to path escaping issues. The fix ensures that windowsPathsNoEscape: true is set when running on Windows (os.platform() === 'win32').

Changes

  • Imported os from node:os to detect the platform.
  • Updated globSync to use windowsPathNoEspace when on Windows.

This sets the `windowsPathsNoEscape: true` on `globSync` when running
on Windows(`os.platform() === 'win32'`) to avoid path escaping issues.
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 85fcf87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@boyney123 boyney123 merged commit bf92c1d into event-catalog:main Feb 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants