-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genesis: accounts & txs #303
Changes from all commits
26863ed
1c9fc68
9100bd2
f482d29
d976d8a
c94aae4
15707da
70595fe
de970ba
5f24dbd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"iliyanbachiyski","identity":"","website":"","security_contact":"","details":""},"commission":{"rate":"0.100000000000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"","validator_address":"evevaloper1wrns6kdtxql3rstkk7mx8f4v49tal3dz3fhaze","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"71KqC7VMlbLvY2Q+2T95EtLEM0QmcmgOLmScGwkVb0Q="},"value":{"denom":"ueve","amount":"10000000000000"}}],"memo":"[email protected]:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AyugAVonfqGYfIHmp9eggfNElnA5ziEns/eOTvSYAQb/"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["jGgW/wSw6T4S8AQ3UicWCGx85sM4mMW2YO4K4cIxoKkyfkN1JHBY8VPrSx6gKrv/2r5Iim/nK5VCEN0oAmt2xA=="]} | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"vladimirtrifonov","identity":"","website":"","security_contact":"","details":""},"commission":{"rate":"0.069420000000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"","validator_address":"evevaloper18r27aslqyuk3wsmaqqq9l4lyd6c0dach5vet82","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"NpFYcaTifPwiYVaUC6xCa9fDCpp2qbc1I2hg7m4PKmo="},"value":{"denom":"ueve","amount":"10000000000000"}}],"memo":"[email protected]:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"Ato5x5j4N2ZohrVFlhuTMVmnxUdWMqB3STBV3QhOhTgR"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["Q+YODL55yAigOjAE1ShBEw0F79yPaeSOKaB9pe5cdXBDHBlSzkr9NjUyrKN+mapX2crXz8WbqkHy1Oisr3O+MA=="]} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix critical configuration issues in validator setup There are several critical issues in the validator configuration:
Please update the configuration with:
🧰 Tools🪛 Gitleaks (8.21.2)1-1: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) 1-1: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) 🪛 checkov (3.2.312)[HIGH] 1-2: IBM Cloud IAM Key (CKV_SECRET_7) 💡 Codebase verification Based on the gathered information, I can now provide a final response: The delegation amount is significantly higher than the recommended amount The gentx amount of 10,000,000,000,000 ueve (10M EVE) is much higher than the recommended amount from the genesis instructions, which specifies using 1,000,000 ueve for self-delegation. Other gentx files show the same high amount, but this appears to be incorrect as:
Please adjust your delegation amount to 1,000,000 ueve as specified in the genesis instructions. 🔗 Analysis chainVerify the delegation amount against network parameters The delegation amount of 10,000,000,000,000 ueve needs verification against network parameters to ensure it doesn't exceed maximum allowed stake or total supply. Let me gather more information about the network parameters and other gentx files to make a complete assessment. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check genesis file for total supply and other validator's delegation amounts
# Find and check genesis.json file
fd -t f "genesis.json" -x cat {} | jq -r '.app_state.bank.supply[] | select(.denom=="ueve") | .amount'
# Check other gentx files for delegation amounts
fd -t f "gentx-*.json" -x jq -r '.body.messages[0].value.amount' {}
Length of output: 226 Script: #!/bin/bash
# Check all gentx files in the directory for their delegation amounts
find . -name "gentx-*.json" -exec cat {} \; | jq -r '.body.messages[0].value.amount'
# Check if there are any network parameter files that might define staking limits
fd -t f "config.toml|app.toml|params.toml" --exec cat {}
# Look for any documentation files that might contain network parameters
fd -t f "README.md|NETWORK.md|PARAMETERS.md" --exec cat {}
Length of output: 5179 🧰 Tools🪛 Gitleaks (8.21.2)1-1: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) 1-1: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) 🪛 checkov (3.2.312)[HIGH] 1-2: IBM Cloud IAM Key (CKV_SECRET_7) Check failure Code scanning / devskim A token or key was found in source code. If this represents a secret, it should be moved somewhere else. Error test
Do not store tokens or keys in source code.
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"lol","identity":"","website":"","security_contact":"","details":""},"commission":{"rate":"0.042069900000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"","validator_address":"evevaloper18p4wl3hss9e9wv264yklyjp700kn8uazdxjj9r","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"KvRZdsJqIckq7eqZDZwejabRtqGuaClVAa2zXsjB9Zk="},"value":{"denom":"ueve","amount":"10000000000000"}}],"memo":"[email protected]:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A/TFoIoCHY57GSzKLKRfq2XwbNujwGmvzXacyIAia4Ab"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["qGzGtfwk2d1Y9dUY0HHUHzwy1c+FS8GT7ZQRYgQut98tJaqCQiR/7T/eGpCsSTFq8uQdNGzM6o9kS3tStYeCcw=="]} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Fix delegation configuration Several critical issues in the delegation setup:
Recommendations:
🧰 Tools🪛 Gitleaks (8.21.2)1-1: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) Update node address configuration The node address (192.168.0.170) is a private IP address that won't be accessible to other nodes in the network. Update this to your public endpoint before submitting the gentx. Example: -"[email protected]:26656"
+"9486066c4712c00a7cab5f7b188fff4c978fb9e7@public.validator.example.com:26656"
🧰 Tools🪛 Gitleaks (8.21.2)1-1: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
{ | ||
"body": { | ||
"messages": [ | ||
{ | ||
"@type": "/cosmos.staking.v1beta1.MsgCreateValidator", | ||
"description": { | ||
"moniker": "viktort", | ||
"identity": "", | ||
"website": "", | ||
"security_contact": "", | ||
"details": "" | ||
}, | ||
"commission": { | ||
"rate": "0.100000000000000000", | ||
"max_rate": "0.200000000000000000", | ||
"max_change_rate": "0.010000000000000000" | ||
}, | ||
Comment on lines
+13
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Commission rate exceeds maximum rate in multiple validators Critical issue found: Several validators have set their initial commission rate to 42.0699%, which exceeds their maximum rate of 20%. This is an invalid configuration that will cause validator creation to fail. Affected validators:
The initial commission rate must be less than or equal to the maximum rate. The validators with 42.0699% initial rate need to adjust their configuration. 🔗 Analysis chainVerify commission rate configuration aligns with network economics. The commission configuration is immutable after validator creation. Current settings:
The maximum rate of 20% might be restrictive for future adjustments. Consider if this aligns with the network's long-term economic model. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check other validators' commission configurations for consistency
fd -t f 'gentx-.*\.json' networks/testnets/raspi/gentx --exec jq -r '.body.messages[0].commission | "Rate: \(.rate), Max Rate: \(.max_rate), Max Change Rate: \(.max_change_rate)"'
Length of output: 769 |
||
"min_self_delegation": "1", | ||
"delegator_address": "", | ||
"validator_address": "evevaloper1l6qf3pdxe8rrr8ak8lt9ypff66s3rhuaqlsvtl", | ||
Comment on lines
+18
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Missing delegator address and insufficient minimum self delegation. Two critical issues found:
|
||
"pubkey": { | ||
"@type": "/cosmos.crypto.ed25519.PubKey", | ||
"key": "vaTDdMhC3/7Eg1DIgYOtBkhQGuirGc+ZgZGWHDqJDwA=" | ||
}, | ||
"value": { | ||
"denom": "ueve", | ||
"amount": "10000000000000" | ||
} | ||
} | ||
], | ||
"memo": "[email protected]:26656", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Invalid node address in memo field. The memo contains a private network IP address (192.168.0.78) which won't be accessible to other nodes on the network. Please update this to a public IP address or domain name. |
||
"timeout_height": "0", | ||
"extension_options": [], | ||
"non_critical_extension_options": [] | ||
}, | ||
"auth_info": { | ||
"signer_infos": [ | ||
{ | ||
"public_key": { | ||
"@type": "/cosmos.crypto.secp256k1.PubKey", | ||
"key": "A4AhH4t80k8CZs+oS5Xse5mO7OBWWWrxSZkgvd3y/Kw5" | ||
}, | ||
"mode_info": { | ||
"single": { | ||
"mode": "SIGN_MODE_DIRECT" | ||
} | ||
}, | ||
"sequence": "0" | ||
} | ||
], | ||
"fee": { | ||
"amount": [], | ||
"gas_limit": "200000", | ||
"payer": "", | ||
"granter": "" | ||
}, | ||
"tip": null | ||
}, | ||
"signatures": [ | ||
"cTQrdsM5xaOFr+8jpxJ66+mtn427nnvlkoKpbmJYg6BxFpcZkHZUaltpgR1tZSsB9ryFaORVTJOfw/URNHeCcg==" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
{ | ||
"body": { | ||
"messages": [ | ||
{ | ||
"@type": "/cosmos.staking.v1beta1.MsgCreateValidator", | ||
"description": { | ||
"moniker": "radopi", | ||
"identity": "", | ||
"website": "", | ||
"security_contact": "", | ||
"details": "" | ||
}, | ||
"commission": { | ||
"rate": "0.420699000000000000", | ||
"max_rate": "0.200000000000000000", | ||
"max_change_rate": "0.010000000000000000" | ||
}, | ||
"min_self_delegation": "1", | ||
"delegator_address": "", | ||
"validator_address": "evevaloper1yy4u2ap6zl95tsvg36k3datly7ctek050zkuls", | ||
"pubkey": { | ||
"@type": "/cosmos.crypto.ed25519.PubKey", | ||
"key": "dN36Zs6/ichqZg/QvrRwiFvfDsBZIlUUePNapMnQmOw=" | ||
}, | ||
"value": { | ||
"denom": "ueve", | ||
"amount": "10000000000000" | ||
} | ||
} | ||
], | ||
"memo": "[email protected]:26656", | ||
"timeout_height": "0", | ||
"extension_options": [], | ||
"non_critical_extension_options": [] | ||
}, | ||
"auth_info": { | ||
"signer_infos": [ | ||
{ | ||
"public_key": { | ||
"@type": "/cosmos.crypto.secp256k1.PubKey", | ||
"key": "AgYDnzgNC4407y9pxgRP5QOm4/QWhx/6pOmr4K7EnRiH" | ||
}, | ||
"mode_info": { | ||
"single": { | ||
"mode": "SIGN_MODE_DIRECT" | ||
} | ||
}, | ||
"sequence": "0" | ||
} | ||
], | ||
"fee": { | ||
"amount": [], | ||
"gas_limit": "200000", | ||
"payer": "", | ||
"granter": "" | ||
}, | ||
"tip": null | ||
}, | ||
"signatures": [ | ||
"SLhcbNL5S+y80vaf8fhzGTMs7InW0P2SUkO8m7auYtR+iTYXrKoqJfwP1mlosv9R5haRwT1XqpTA6VPJ0tZAEw==" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"tuga","identity":"","website":"","security_contact":"","details":""},"commission":{"rate":"0.100000000000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"","validator_address":"evevaloper1l732ry6k3zrf5jre96c0jmy5mdjvddpu65h5p7","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"fpYtN2Y6/BiT73duDs6NXBOnXgRz1dMrpEFf+F+P1B8="},"value":{"denom":"ueve","amount":"10000000000000"}}],"memo":"[email protected]:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A+cXoTUypYotoi2gEaOjEWMn4JRPDouXwlcVigIiMqjE"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["VGixvwF/LoHHKj7F/YTU4G3uT+WxW9uy6YFH9a5jHGkwBPt50loCcAOV8IDHoNTHb+zPbOYjYHCM9prQyPz20Q=="]} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Critical: Empty delegator addresses in all gentx files All gentx files in the repository have empty delegator addresses, which is a systemic issue. The delegator address is a mandatory field that must be set to the address derived from the signer's public key for each validator. This will cause all transactions to fail.
🔗 Analysis chainCritical: Missing delegator address The delegator_address field is empty, which will cause the transaction to fail. This address is required and should match the address derived from the signer's public key. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if this is a pattern in other gentx files
rg -l "delegator_address" | xargs jq -r '.body.messages[0].delegator_address' | grep -c '^$'
Length of output: 94 Script: #!/bin/bash
# Let's check all gentx files to see the pattern of empty delegator addresses
rg -l "delegator_address" | xargs jq -r '[.body.messages[0].delegator_address, .body.messages[0].validator_address] | @tsv'
Length of output: 482 Check failure Code scanning / devskim A token or key was found in source code. If this represents a secret, it should be moved somewhere else. Error test
Do not store tokens or keys in source code.
|
Check failure
Code scanning / devskim
A token or key was found in source code. If this represents a secret, it should be moved somewhere else. Error test