Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

begin gentx for PiNet #302

Merged
merged 1 commit into from
Dec 5, 2024
Merged

begin gentx for PiNet #302

merged 1 commit into from
Dec 5, 2024

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 5, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Introduced a new transaction JSON file for creating a validator in the Cosmos blockchain, including essential fields like description, commission rates, and delegation details.
  • Bug Fixes
    • Removed outdated JSON files that contained unnecessary or duplicate validator transaction information.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves the deletion of multiple JSON files that represented transactions for creating validators in the Cosmos blockchain network. Each file contained similar structures, including fields for validator descriptions, commission rates, self-delegation requirements, and transaction details. The changes also include the addition of a new JSON file that introduces a new validator creation transaction with specified attributes.

Changes

File Path Change Summary
networks/testnets/gentx/andromeda.json Deleted: JSON object for validator creation with details on commission, public key, and fees.
networks/testnets/gentx/gentx-063230a84cfd5fa4e594a7550e94f636f573b22d.json Deleted: JSON object for validator creation with similar structure and transaction details.
networks/testnets/gentx/gentx-4bf1f0bac90563207918894a7da05f8a8f0d0903.json Deleted: JSON object for validator creation with detailed attributes including delegator and validator addresses.
networks/testnets/gentx/gentx-528664215506e33c9a525342153afeb411468fbe.json Deleted: JSON object for validator creation with commission rates and public key information.
networks/testnets/gentx/gentx-ArchitectNodes.json Deleted: JSON object for validator creation with attributes like commission and self-delegation.
networks/testnets/gentx/gentx-EigenNode.json Deleted: JSON object for validator creation with detailed validator description and transaction info.
networks/testnets/gentx/gentx-Enigma.json Deleted: JSON object for validator creation including commission rates and public key.
networks/testnets/gentx/gentx-HoodRun.json Deleted: JSON object for validator creation with details on commission and staking experience.
networks/testnets/gentx/gentx-Maximoff.json Deleted: JSON object for validator creation with transaction details and signature.
networks/testnets/gentx/gentx-NodeStake.json Deleted: JSON object for validator creation with detailed commission and delegation information.
networks/testnets/gentx/gentx-Nodeist.json Deleted: JSON object for validator creation with detailed attributes and signer information.
networks/testnets/gentx/gentx-Zenscape.json Deleted: JSON object for validator creation with attributes including commission and timeout height.
networks/testnets/gentx/gentx-node101.json Deleted: JSON object for validator creation with detailed transaction attributes.
networks/testnets/geonodes-gentx.json Deleted: JSON object for validator creation with details on commission and public key.
networks/testnets/gentx/web3cdn.json Deleted: JSON object for validator creation with transaction details and signature.
networks/testnets/raspi/gentx/gentx-856d266156a8daa399a74bf9c9e387d53054a3dc.json Added: New JSON object for validator creation with detailed attributes including commission and delegation.

Possibly related PRs

  • Add gentx-andromeda.json #225: The changes in andromeda.json are directly related as both files represent transactions for creating validators in the Cosmos blockchain network, detailing similar attributes such as commission rates and public key information.
  • Add gentx-EigenNode.json #226: The gentx-EigenNode.json file also contains a message for creating a validator, sharing similar structure and fields with the main PR.
  • Add gentx-Zenscape.json #227: The gentx-Zenscape.json file includes a message to create a validator, with overlapping details regarding commission rates and validator attributes.
  • Create gentx-HoodRun.json #231: The gentx-HoodRun.json file is related as it also details a transaction for creating a validator, including similar fields and structure.
  • Create web3cdn.json #235: The web3cdn.json file contains a message for creating a validator, sharing the same purpose and structure as the main PR.

Suggested reviewers

  • hoank101

🐇 In the cosmos where validators play,
A JSON dance has led the way.
With fields of tokens, rates, and more,
New structures rise, old ones no more.
Hopping through code, we celebrate,
A fresh validator, isn't it great? 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9ffcd3f and e4326b6.

📒 Files selected for processing (16)
  • networks/testnets/gentx/andromeda.json (0 hunks)
  • networks/testnets/gentx/gentx-063230a84cfd5fa4e594a7550e94f636f573b22d.json (0 hunks)
  • networks/testnets/gentx/gentx-4bf1f0bac90563207918894a7da05f8a8f0d0903.json (0 hunks)
  • networks/testnets/gentx/gentx-528664215506e33c9a525342153afeb411468fbe.json (0 hunks)
  • networks/testnets/gentx/gentx-ArchitectNodes.json (0 hunks)
  • networks/testnets/gentx/gentx-EigenNode.json (0 hunks)
  • networks/testnets/gentx/gentx-Enigma.json (0 hunks)
  • networks/testnets/gentx/gentx-HoodRun.json (0 hunks)
  • networks/testnets/gentx/gentx-Maximoff.json (0 hunks)
  • networks/testnets/gentx/gentx-NodeStake.json (0 hunks)
  • networks/testnets/gentx/gentx-Nodeist.json (0 hunks)
  • networks/testnets/gentx/gentx-Zenscape.json (0 hunks)
  • networks/testnets/gentx/gentx-node101.json (0 hunks)
  • networks/testnets/gentx/geonodes-gentx.json (0 hunks)
  • networks/testnets/gentx/web3cdn.json (0 hunks)
  • networks/testnets/raspi/gentx/gentx-856d266156a8daa399a74bf9c9e387d53054a3dc.json (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@faddat faddat merged commit c41f122 into main Dec 5, 2024
7 checks passed
@faddat faddat deleted the faddat/gentx-begin branch December 5, 2024 11:12
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2024
View reviewed changes
networks/testnets/raspi/gentx/gentx-856d266156a8daa399a74bf9c9e387d53054a3dc.json
@@ -0,0 +1 @@
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"x.com/gadikian","identity":"","website":"","security_contact":"x.com/gadikian","details":""},"commission":{"rate":"0.069420000000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"","validator_address":"evevaloper16hpk4083nxajqhuc3rh9lvxpw6rz8z60z4dycu","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"7i7kP0cHHjaLYvJRrxVC9c4YlWIPi4CsxfOh1G6CCGw="},"value":{"denom":"ueve","amount":"10000000000000"}}],"memo":"856d266156a8daa399a74bf9c9e387d53054a3dc@192.168.1.39:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"Ag4M1ULY19Dd1vzWUe55GDVowGwGDmfgAPD/ZByq/yYi"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["CVX55TCiCkzU/JD/kj1wVt9pu3lkQWcDAhJsUT+v+NpWFGLo5ZqIiDt5/F/eC8+xdHkhRkzHO+SPYryToKlrXg=="]}

Check failure

Code scanning / devskim

A token or key was found in source code. If this represents a secret, it should be moved somewhere else. Error test

Do not store tokens or keys in source code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@faddat