Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass bank keeper to ante handler #292

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

tgntr
Copy link
Contributor

@tgntr tgntr commented Dec 4, 2024

ante handler was throwing error that bank keeper is nil, because we were not passing it

Summary by CodeRabbit

  • New Features

    • Introduced a post-handler for transaction processing, ensuring accurate fee deductions.
    • Enhanced ante handler functionality to interact with the bank module for improved transaction fee management.
  • Improvements

    • Updated block finalization process to include checks for consensus parameters, ensuring compatibility with upgraded SDK versions.

Copy link
Contributor

coderabbitai bot commented Dec 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on enhancing the EveApp structure within the app/app.go file. A new method, setPostHandler, has been introduced to manage post-processing of transactions with fee considerations. The existing setAnteHandler method has been updated to incorporate the BankKeeper, improving transaction fee management. Additionally, the FinalizeBlock method now includes logic for handling consensus parameter migration, ensuring compatibility with upgraded SDK versions. These modifications collectively aim to improve transaction handling and fee management within the application.

Changes

File Change Summary
app/app.go - Added method setPostHandler() for post-processing with fee deductions.
- Updated setAnteHandler to include BankKeeper for enhanced transaction processing.
- Modified FinalizeBlock to check and handle consensus parameter migration during block finalization.

Poem

In the garden of code, where the rabbits play,
New methods hop in, brightening the day.
With fees all accounted, and blocks that align,
Our EveApp now dances, in rhythm, divine! 🐇✨
Let's celebrate changes, both clever and neat,
For in every line, our progress is sweet!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between dae4084 and e4289c7.

📒 Files selected for processing (1)
  • app/app.go (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@faddat faddat marked this pull request as ready for review December 4, 2024 08:49
@faddat faddat merged commit 13ce20b into eve-network:main Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants