refactor: disable ics

[hoank101]

disable ics, will open when it stable

Summary by CodeRabbit

• Refactor
  • Removed unused imports and declarations enhancing app performance.
  • Adjustments in app setup for improved module management.
• New Features
  • Integrated a new staking module to enhance app functionalities.
• Chores
  • Updated local node start script with new timing configurations and commission rate settings for genesis transactions.

[coderabbitai]

Walkthrough

The recent updates streamline blockchain functionality by phasing out interchain-security components in favor of enhanced staking mechanisms. The modifications include removing obsolete references, introducing staking features, and adjusting blockchain parameters to optimize performance. This transition marks a significant shift towards more robust and efficient blockchain operations.

Changes

File(s)	Summary of Changes
app/ante.go	Removed interchain-security imports, eliminated ConsumerKeeper, adjusted NewAnteHandler function.
app/app.go	Added staking imports, replaced ConsumerKeeper with StakingKeeper, added staking module setup.
scripts/.../start_local_node.sh	Updated blockchain parameters, commented out consumer addition, added commission rate settings.

🐇✨
To the blockchain, we hop and tweak,
Farewell to the old, the new we seek.
Staking now where once was none,
Under the moon, and soon the sun.
A leap, a bound, into the dawn,
With every line of code we spawn.
🌟🚀🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 5c3a2f1 and 958fbbe.

Files selected for processing (3)

• app/ante.go (3 hunks)
• app/app.go (9 hunks)
• scripts/start_local_node.sh (3 hunks)

Check Runs (1)

lint completed (5)

• app/app.go: 12-12: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) -s prefix(github.com/CosmWasm/wasmd) --custom-order (gci)
• app/app.go: 51-51: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) -s prefix(github.com/CosmWasm/wasmd) --custom-order (gci)
• app/app.go: 144-144: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) -s prefix(github.com/CosmWasm/wasmd) --custom-order (gci)

Additional comments: 10

scripts/start_local_node.sh (3)

• 12-14: The update to MAX_DEPOSIT_PERIOD, VOTING_PERIOD, and UNBONDING_TIME from 20 seconds to 86401 seconds is consistent with the PR objectives to adjust the application's operational parameters in light of the disabled ICS feature. This change will significantly impact the governance and staking processes by extending the time frames for deposits, voting, and unbonding, which should be carefully considered for its impact on the user experience and system performance.
• 41-42: Commenting out the add-consumer-section and the related jq command for setting the unbonding_period aligns with the objective to disable the ICS feature. However, it's important to ensure that this does not inadvertently affect other functionalities or leave the system in an inconsistent state. If this is a temporary measure, consider adding a TODO comment to revisit and re-enable these sections once ICS becomes stable.
• 52-56: Adding commission rate settings for genesis transactions with COMMISSION_RATE and COMMISSION_MAX_RATE variables is a good practice for configuring validator incentives. Ensure that these rates are aligned with the project's governance and economic models. It's also important to validate these settings against the network's expectations and to document any changes for network participants.

app/ante.go (1)

• 60-60: The removal of a decorator related to disabled modules in the NewAnteHandler function is consistent with the PR's objective to disable the ICS feature. However, it's crucial to ensure that this does not compromise the application's security or functionality. Removing decorators can have unintended side effects, especially in the context of transaction processing and validation. It would be beneficial to perform thorough testing to verify that all remaining decorators function as expected without the removed decorator.

app/app.go (6)

• 12-13: The imports for github.com/cosmos/cosmos-sdk/x/staking and github.com/cosmos/interchain-security/v4/x/ccv/democracy/staking have been added. This aligns with the PR's objective to shift towards using staking functionalities in the absence of ICS. However, ensure that the import statements are organized according to the Go conventions and the project's import grouping rules.

Consider organizing import statements to improve readability and maintain consistency with Go conventions and project-specific guidelines.

• 434-434: The reference to StakingKeeper is correctly updated from ConsumerKeeper in the SlashingKeeper initialization. This change is necessary due to the disabling of ICS and the shift towards using staking functionalities.
• 524-524: The reference to StakingKeeper is correctly updated from ConsumerKeeper in the IBCKeeper initialization. This change aligns with the PR's objective and is correctly implemented.
• 543-543: The reference to StakingKeeper is correctly updated from ConsumerKeeper in the IBCKeeper initialization. This change aligns with the PR's objective and is correctly implemented.
• 770-770: The addition of the staking module in the app setup is correctly implemented, aligning with the PR's objective to shift focus towards staking functionalities in the absence of ICS.
• 770-770: The addition of ccvstaking.NewAppModule alongside the standard staking.NewAppModule might introduce redundancy or confusion, as both seem to be related to staking functionalities but from different sources. It's important to clarify the distinct roles or functionalities these modules provide to avoid potential overlap or confusion.

Consider providing additional comments or documentation to clarify the distinct roles or functionalities of ccvstaking.NewAppModule and staking.NewAppModule to ensure clear understanding and maintainability.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 958fbbe and fb83f20.

Files selected for processing (1)

• app/app.go (8 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/app.go