-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token factory sdk 50 #155
token factory sdk 50 #155
Conversation
WalkthroughThe changes integrate the Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
10629d1
to
8ccfabc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.mod
is excluded by:!**/*.mod
go.sum
is excluded by:!**/*.sum
Files selected for processing (1)
- app/app.go (12 hunks)
Additional comments: 4
app/app.go (4)
- 48-51: The new imports related to the token factory are correctly added. Ensure that the versions of these imports are compatible with the rest of the project dependencies to avoid any conflicts.
- 249-250: The addition of
TokenFactoryKeeper
to theEveApp
struct is necessary for integrating the token factory functionality. Ensure that it is properly initialized and used throughout the application lifecycle.- 505-512: The initialization of
TokenFactoryKeeper
with necessary dependencies is correctly done. Verify that all dependencies passed during initialization are correctly configured and that the keeper is initialized at the appropriate point in the application lifecycle.- 188-192: The integration of the token factory module into the module manager and its inclusion in various parts of the application lifecycle are correctly done. Ensure that the module's lifecycle integration and permissions are thoroughly reviewed to avoid any potential issues with module interactions and permissions.
Also applies to: 747-747, 794-794, 812-812, 853-853
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- app/app.go (11 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/app.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Notes
token factory - cosmos sdk 0.50 notional-labs/tokenfactory#2
eve
Related Issues
#126
Summary by CodeRabbit