Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token factory sdk 50 #155

Merged
merged 9 commits into from
Mar 11, 2024
Merged

token factory sdk 50 #155

merged 9 commits into from
Mar 11, 2024

Conversation

duvbell
Copy link

@duvbell duvbell commented Mar 8, 2024

Notes

Related Issues

#126

Summary by CodeRabbit

  • New Features
    • Integrated Token Factory functionalities, enhancing app capabilities with new token management features.

Copy link
Contributor

coderabbitai bot commented Mar 8, 2024

Walkthrough

The changes integrate the tokenfactory module into the EveApp application, enhancing its functionality by adding support for token creation and management. This includes importing necessary components, setting up permissions, and incorporating the module into the application's structure and initialization processes. This effort aligns with improving blockchain capabilities and interoperability with other projects, such as Osmosis.

Changes

File(s) Summary of Changes
app/app.go Introduced tokenfactory imports, added TokenFactoryKeeper, and integrated tokenfactory module setup.
app/.../initParamsKeeper.go Initialized parameter key tables for tokenfactorytypes.

Related issues

  • Token Factory #126: This PR likely addresses the objective of ensuring Eve supports the token factory, as it integrates tokenfactory modules, which is a step towards compatibility with updated SDK versions mentioned in the issue.

🐰✨
In the realm of code, where the bits do hop,
A rabbit worked hard, without a stop.
Tokens to create, and chains to bind,
In EveApp's embrace, solutions we find.
To the future, we leap, with joy we sing,
For in our code, new possibilities take wing.
🚀🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@duvbell duvbell marked this pull request as draft March 8, 2024 10:03
@duvbell duvbell changed the title feat: add notinal lab token factory token factory sdk 50 Mar 8, 2024
@duvbell duvbell force-pushed the feat/token-factory branch from 10629d1 to 8ccfabc Compare March 10, 2024 16:31
@duvbell duvbell marked this pull request as ready for review March 10, 2024 16:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6905b9f and 8ccfabc.
Files ignored due to path filters (2)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • app/app.go (12 hunks)
Additional comments: 4
app/app.go (4)
  • 48-51: The new imports related to the token factory are correctly added. Ensure that the versions of these imports are compatible with the rest of the project dependencies to avoid any conflicts.
  • 249-250: The addition of TokenFactoryKeeper to the EveApp struct is necessary for integrating the token factory functionality. Ensure that it is properly initialized and used throughout the application lifecycle.
  • 505-512: The initialization of TokenFactoryKeeper with necessary dependencies is correctly done. Verify that all dependencies passed during initialization are correctly configured and that the keeper is initialized at the appropriate point in the application lifecycle.
  • 188-192: The integration of the token factory module into the module manager and its inclusion in various parts of the application lifecycle are correctly done. Ensure that the module's lifecycle integration and permissions are thoroughly reviewed to avoid any potential issues with module interactions and permissions.

Also applies to: 747-747, 794-794, 812-812, 853-853

@duvbell duvbell marked this pull request as draft March 10, 2024 16:45
@duvbell duvbell marked this pull request as ready for review March 10, 2024 17:35
@duvbell duvbell requested review from faddat and hoank101 March 10, 2024 17:36
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8ccfabc and 7c895b6.
Files selected for processing (1)
  • app/app.go (11 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/app.go

Copy link
Contributor

@hoank101 hoank101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoank101 hoank101 merged commit f96264e into main Mar 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants