Rename QubitBasis::add to ::index
#252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// return the address of the state | ||
| size_t add() const { return state_; } | ||
| /// Convenience function to return state_ as an index. | ||
| size_t index() const { return static_cast<size_t>(state_); } |
There was a problem hiding this comment.
Because this is probably a new feature for you: static_cast is a way of saying very very explicitly that we're doing a type conversion.
There was a problem hiding this comment.
Strange as it may sound, I knew of static_cast :-).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames a very misleadingly named function.
User Notes
QubitBasis.add()is now accessed asQubitBasis.index()Checklist