get_pauli_permuted_idx now returns size_t
#251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imagoulas
approved these changes
May 16, 2024
| @@ -874,7 +874,7 @@ std::complex<double> Computer::direct_pauli_circ_exp_val(const Circuit& qc) { | |||
| std::vector<int> y_idxs; | |||
| std::vector<int> z_idxs; | |||
|
|
|||
| for (const Gate& gate : qc.gates()) { | |||
| for (const auto& gate : qc.gates()) { | |||
There was a problem hiding this comment.
Out of curiosity, why was this changed to auto?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
get_pauli_permuted_idxutility function now returns asize_trather than anintas its first argument. The method's only use is as an argument tostd::next, which logically should be expecting asize_t.Comments,
auto, and changing other things tosize_tto match also included.Checklist