CER-2-Operator High Priority Rules #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpawlowski
requested changes
Feb 16, 2024
certora/specs/CER-2-Operator/CER-52-Operator-deauthorization.spec
Outdated
Show resolved
Hide resolved
andrew-certora
force-pushed
the
andrew@CER-2-Operator
branch
from
bab67ba to
0f7cc3f
Compare
kasperpawlowski
requested changes
Feb 19, 2024
certora/specs/CER-2-Operator/CER-52-Operator-deauthorization.spec
Outdated
Show resolved
Hide resolved
kasperpawlowski
previously approved these changes
Feb 20, 2024
nd-certora
reviewed
Mar 5, 2024
Signed-off-by: andrew-certora <[email protected]>
andrew-certora
force-pushed
the
andrew@CER-2-Operator
branch
from
0b3f12d to
a20c005
Compare
|
is it ready to be reviewed? |
This recent commit: d912753 Changes how initialization works, so it is no longer the default value needed for the invariant causing the invariant to fail. This PR just updates our harness to repair this. Run with updated default: https://prover.certora.com/output/65266/9ff51a4bb5f84119a9d37bcddfd06ddf?anonymousKey=32a5bcd5cbb34bf68ae9ab84feaf069813bf7e74
Yes. I am using the draft feature of github. If it is not marked as draft it really means I believe it is ready to be reviewed. (Though of course if you prefer a different process let me know). I also believe I now addressed Nurit's suggestion which I think has improved the rule. |
kasperpawlowski
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prove the last 2 high priority CER-2 rules:
CER-52: https://linear.app/euler-labs/issue/CER-52/operator-deauthorization
CER-54: https://linear.app/euler-labs/issue/CER-54/operator-does-not-belong-to-the-owner