Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in the GeoJSON file from https://geoportal.un.org/arcgis/apps/sites/#/geohub/datasets/d7caaff3ef4b4f7c82689b7c4694ad92/about, provided by the United Nations.
To generate this file I have manually:
I think the right way to do this would be to add in a new script to
bin/
which allows us to scrape from UN directly and calls the Mapshaper API to generate the built files.However, our real goal is just to test whether this file works with Plotly.js in the first place, so making a placeholder PR with the right dataset and reference data.
Though, after digging into this project a bit, I'm worried that this is out-of-scope. All of the GeoJSON files in this repository come from Natural Earth, which we're trying to move away from in Plotly.js:
sane-topojson
alone and make a new package..? Or even bundle the UN files directly into Plotly.js?world_110m
andworld_50m
both contain borders for US states and Canadian provinces. We might need to add that data to the UN GeoJSON?iso3cd
in the UN data corresponds toid
in the Natural Earth data. Most other metadata I think we can throw out.