Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request adding Oceania support #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jianqing-shi
Copy link

Added Oceania into the list, maybe ajustment on numbers are needed.
I think it is important to support all the continents.

Added Oceania into the list, maybe ajustment on numbers are needed.
I think it is important to support all the continents.
config.json Outdated
"src": "admin_0_countries",
"key": "continent",
"val": "Oceania",
"bounds": [-10, -50, -180, 100]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://en.wikipedia.org/wiki/Oceania

image

Oceania extends all the way to the Easter Island at 109°22′W.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the remark! Sorry for the delay as I am having many projects at the same time...
I have modified the file.

@irv075
Copy link

irv075 commented Oct 12, 2018

Hi, is this PR likely to be merged soon? I'm really looking forward to getting Oceania into Plotly.js, thanks!

@etpinard
Copy link
Owner

@irv075 @jianqing-shi Sorry for the delay.

This package is now back alive (a lot of things have changed in the Natural Earth dataset since 2016 which made this package unusage before #12).

Now, I'm still not 100% sure how to define the Oceania scope. It would be great to do a little research and check what other geo libraries are doing.

Thanks very much again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants