-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request adding Oceania support #10
base: master
Are you sure you want to change the base?
Conversation
Added Oceania into the list, maybe ajustment on numbers are needed. I think it is important to support all the continents.
config.json
Outdated
"src": "admin_0_countries", | ||
"key": "continent", | ||
"val": "Oceania", | ||
"bounds": [-10, -50, -180, 100] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://en.wikipedia.org/wiki/Oceania
Oceania extends all the way to the Easter Island at 109°22′W.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the remark! Sorry for the delay as I am having many projects at the same time...
I have modified the file.
Hi, is this PR likely to be merged soon? I'm really looking forward to getting Oceania into Plotly.js, thanks! |
@irv075 @jianqing-shi Sorry for the delay. This package is now back alive (a lot of things have changed in the Natural Earth dataset since 2016 which made this package unusage before #12). Now, I'm still not 100% sure how to define the Oceania scope. It would be great to do a little research and check what other geo libraries are doing. Thanks very much again for your help! |
Added Oceania into the list, maybe ajustment on numbers are needed.
I think it is important to support all the continents.