add check,attack root, non-zero branch returns an error

ethstorage · Nov 29, 2024 · 4ba3d10 · 4ba3d10
1 parent d7f7e67
commit 4ba3d10
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/op-challenger2/game/fault/solver/game_solver.go b/op-challenger2/game/fault/solver/game_solver.go
@@ -104,7 +104,7 @@ func (s *GameSolver) calculateMove(ctx context.Context, game types.Game, claim t
 			return nil, nil
 		}
 		if claim.IsRoot() && branch != 0 {
-			return nil, nil
+			return nil, fmt.Errorf("cannot attack root claim with branch %v", branch)
 		}
 		move, err := s.claimSolver.NextMove(ctx, claim, game, honestClaims, uint64(branch))
 		if err != nil {

diff --git a/op-challenger2/game/fault/test/claim_builder.go b/op-challenger2/game/fault/test/claim_builder.go
@@ -178,9 +178,6 @@ func (c *ClaimBuilder) claim(pos types.Position, opts ...ClaimOpt) types.Claim {
 			} else {
 				values = append(values, c.CorrectClaimAtPosition(pos))
 			}
-			for i := uint64(0); i < c.MaxAttackBranch()-1; i++ {
-				values = append(values, common.Hash{})
-			}
 		} else if pos.Depth() == c.splitDepth+types.Depth(c.nbits) {
 			values = append(values, c.CorrectClaimAtPosition(pos))
 			for i := uint64(0); i < c.MaxAttackBranch()-1; i++ {