chore: bump libp2p to v0.33.2 #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istae
approved these changes
Apr 23, 2024
janos
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
The upgrade is ok from the libp2p package api, but it should be tested against nodes that run libp2p v0.30.0 for possible regressions. I suggest to have some canary nodes updates that currently have memory issues visible on the metrics dashboards.
The upgrade for the whole libp2p stack is quite extensive in order to fix a timer leak with a one line. If problems are detected, I suggest to use a patched version of libp2p v0.30.0 and to deal with the complexities of extensive testing in time, without rush, as this memory leak is an urgent issue.
istae
pushed a commit
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.