Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: update license headers and AUTHORS #30948

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ronething-bot
Copy link
Contributor

@ronething-bot ronething-bot commented Dec 21, 2024

  • Add license header to files that do not have a license header
  • Update AUTHORS

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't update the year in the license header. Please remove that, the updated AUTHORS file is something that we can merge imo

@ronething-bot
Copy link
Contributor Author

We don't update the year in the license header.

@MariusVanDerWijden Hi, thanks for your review comment.

The year modification of the license header is due to this section of logic processing, ref:

if y < info.Year {
info.Year = y
}

Running build/update-license.go will automatically modify it, and I will revert the modified year of the license header later, or only keep the modifications to the AUTHORS file.

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ronething-bot
Copy link
Contributor Author

@rjl493456442 PTAL, thanks.

@fjl
Copy link
Contributor

fjl commented Jan 4, 2025

It's good to update, but the AUTHORS file requires some manual review. Specifically, we need to ensure that entries are unique. There are two kinds of entries in the file: name + email, and github users. When people contribute via GitHub, it usually uses their GitHub username as the committer. However, some people also push commits with their own email address, and this can lead to duplicates in AUTHORS. The way to resolve that is adding entries into the .mailmap file. I usually update this file whenever we update AUTHORS to ensure there are no obvious duplicates.

@ronething-bot
Copy link
Contributor Author

The way to resolve that is adding entries into the .mailmap file. I usually update this file whenever we update AUTHORS to ensure there are no obvious duplicates.

@fjl I have updated the duplicate items to .mailmap file, please review the latest commit, thanks

ref: 7cd5941

@fjl
Copy link
Contributor

fjl commented Jan 4, 2025

Thanks. I will do another pass myself later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants