-
Notifications
You must be signed in to change notification settings - Fork 20.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: update license headers and AUTHORS #30948
base: master
Are you sure you want to change the base?
Conversation
ronething-bot
commented
Dec 21, 2024
•
edited
Loading
edited
- Add license header to files that do not have a license header
- Update AUTHORS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't update the year in the license header. Please remove that, the updated AUTHORS file is something that we can merge imo
@MariusVanDerWijden Hi, thanks for your review comment. The year modification of the license header is due to this section of logic processing, ref: go-ethereum/build/update-license.go Lines 362 to 364 in 25aa8f6
Running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
@rjl493456442 PTAL, thanks. |
It's good to update, but the AUTHORS file requires some manual review. Specifically, we need to ensure that entries are unique. There are two kinds of entries in the file: name + email, and github users. When people contribute via GitHub, it usually uses their GitHub username as the committer. However, some people also push commits with their own email address, and this can lead to duplicates in AUTHORS. The way to resolve that is adding entries into the |
Thanks. I will do another pass myself later. |