cmd, core, miner: rework genesis setup #30907
Open
+192
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
fjl,
holiman,
karalabe,
gballet,
zsfelfoldi and
MariusVanDerWijden
as code owners
|
I think we should extract the chain config setup into its own function like I did in my branch: https://github.com/fjl/go-ethereum/tree/genesis-verkle-config |
gballet
reviewed
Dec 13, 2024
core/genesis.go
Outdated
| } | ||
| } | ||
| // Get the existing chain configuration. | ||
| // Construct the new chain config either from the supplied genesis, or | ||
| // the stored chain config if nothing specified. | ||
| newcfg := genesis.configOrDefault(stored) |
There was a problem hiding this comment.
we need a better name now, because it's no longer returning any "default". Maybe getUpdatedConfig ?
cmd/utils/flags.go
Outdated
| @@ -2224,7 +2224,6 @@ func MakeTrieDatabase(ctx *cli.Context, disk ethdb.Database, preimage bool, read | |||
| // ignore the parameter silently. TODO(rjl493456442) | |||
| // please config it if read mode is implemented. | |||
| config.HashDB = hashdb.Defaults | |||
| return triedb.NewDatabase(disk, config) | |||
There was a problem hiding this comment.
that means that both config.HashDB and config.PathDB are set, and this is leading to a log.Crit in triedb.NewDatabase. Was this intentional ?
rjl493456442
force-pushed
the
rework-setupgen2
branch
from
7bccc27 to
2204e0e
Compare
rjl493456442
force-pushed
the
rework-setupgen2
branch
from
2204e0e to
d1460c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the genesis setup function, the major changes are highlighted here:
(a) Triedb is opened in verkle mode if
EnableVerkleAtGenesisis configured in chainConfigor the database has been initialized previously with
EnableVerkleAtGenesisconfigured.A new config field
EnableVerkleAtGenesishas been added in the chainConfig. This field mustbe configured with True if Geth wants to initialize the genesis in Verkle mode.
In the verkle devnet-7, the verkle transition is activated at genesis. Therefore, the verkle rules
should be used since the genesis. In production networks (mainnet and public testnets), verkle
activation always occurs after the genesis block. Therefore, this flag is only made for devnet
and should be deprecated later. Besides, verkle transition at non-genesis block hasn't been
implemented yet, it should be done in the following PRs.
(b) The genesis initialization condition has been simplified
There is a special mode supported by the Geth is that: Geth can be initialized with an existing
chain segment, which can fasten the node sync process by retaining the chain freezer folder.
Originally, if the triedb is regarded as uninitialized and the genesis block can be found in the
chain freezer, the genesis block along with genesis state will be committed. This condition
has been simplified to checking the presence of chain config in key-value store. The existence
of chain config can represent the genesis has been committed.