Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test with multiple deposit requests with same pubkey but different withdrawal credentials #4085

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

debjit-bw
Copy link
Contributor

If a block contained multiple deposits with the same pubkey, Grandine would add them to BeaconState.pending_deposits with the same withdrawal credentials. link

This PR adds a test which checks that the withdrawal credentials associated with the same pubkey are retained, rather than being made the same. It randomly picks 2 deposit requests and their pubkeys are made the same as the top deposit.

fixes partially: #4054

@ethereum ethereum deleted a comment from cheyenne-bot Jan 20, 2025
@debjit-bw debjit-bw requested a review from mkalinin January 20, 2025 05:09
Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@mkalinin mkalinin requested a review from jtraglia January 20, 2025 05:11
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thank you! 😄

I pushed two small commits to help readability; notably a check which tells the reader that the top-up withdrawal credentials are indeed different.

@jtraglia jtraglia merged commit 188a2ff into ethereum:dev Jan 20, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants