Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use validator guide compute_on_chain_aggregate in testing #3680

Merged
merged 2 commits into from
Apr 17, 2024
+8 −58
Merged

Use validator guide compute_on_chain_aggregate in testing #3680

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9b5d9
Use validator guide `compute_on_chain_aggregate` in testing
hwwhww Apr 17, 2024
e6e7c92
weird fix
hwwhww Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
weird fix
@hwwhww
hwwhww committed Apr 17, 2024
commit e6e7c92ecaa21106f55807be0f3940a7525723c2
7 changes: 6 additions & 1 deletion specs/electra/validator.md
View file
Original file line number Diff line number Diff line change
@@ -66,7 +66,12 @@ def compute_on_chain_aggregate(network_aggregates: Sequence[Attestation]) -> Att
committee_flags = [(index in committee_indices) for index in range(0, MAX_COMMITTEES_PER_SLOT)]
committee_bits = Bitvector[MAX_COMMITTEES_PER_SLOT](committee_flags)

return Attestation(aggregation_bits, data, committee_bits, signature)
return Attestation(
aggregation_bits=aggregation_bits,
data=data,
committee_bits=committee_bits,
signature=signature,
)
Comment on lines +69 to +74
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I don't understand why this fixed the CI error...

without this fix, the result aggregate.data.target.epoch is 0 when it should be 2 in some tests.

/cc @protolambda, in case you can share some remerkleable wisdom. 🧙‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure either, but I'll just assume there is some subtlety in how remerkleable initializes things

```

#### Deposits