Add EIP: Flow Control Wallet Call Capability #9259
Open
+553
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
File
|
eth-bot
added
e-consensus
eth-bot
changed the title
SamWilsn
force-pushed
the
eip-call-flow-control
branch
from
64b1893 to
114bb1c
Compare
Marchhill
approved these changes
Jan 23, 2025
|
|
||
| #### Rollback | ||
|
|
||
| A rollback is informally defined as "causing no meaningful changes on chain." A |
There was a problem hiding this comment.
Is there any reason to break up lines like this? A paragraph could be on one line and use line wrapping, not sure what the standard is here
There was a problem hiding this comment.
I like a narrow line width, but we accept both wrapped and unwrapped lines.
| | `207` | Partial Success | | ||
|
|
||
| An "included" call, in this section, is defined as having either been | ||
| successfully or unsuccessfully executed. A call that has been recorded on chain, |
There was a problem hiding this comment.
Suggested change
| successfully or unsuccessfully executed. A call that has been recorded on chain, | |
| executed, even if execution was unsuccessful. A call that has been recorded on chain, |
|
|
||
| Status `102` SHALL be returned only when all of the following are true: | ||
|
|
||
| * At least one call in the batch has been included on chain; and |
There was a problem hiding this comment.
Suggested change
| * At least one call in the batch has been included on chain; and | |
| * At least one call in the batch has been included on chain. |
|
|
||
| Status `207` SHALL be returned only when all of the following are true: | ||
|
|
||
| * At least one call in the batch has been included and succeeded; |
There was a problem hiding this comment.
Suggested change
| * At least one call in the batch has been included and succeeded; | |
| * At least one call in the batch has been included and succeeded. |
Same for rest of list, for consistency with other lists
|
|
||
| ## Backwards Compatibility | ||
|
|
||
| <!-- |
SamWilsn
force-pushed
the
eip-call-flow-control
branch
from
114bb1c to
9968288
Compare
Co-authored-by: Marc <[email protected]>
|
The commit 69e1980 (as a parent of 84ef6ef) contains errors. |
Remaong89
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.