Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7691: clarify parameter handling at the fork boundary #9249

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

ralexstokes
Copy link
Member

adds some text to clarify that the new values should be used within the fork activation block.

so that pre-fork, the old values are used, and at the first block of the new fork, the new values are used

@ralexstokes ralexstokes requested a review from eth-bot as a code owner January 16, 2025 19:52
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Jan 16, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 16, 2025

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Jan 16, 2025
@eth-bot eth-bot changed the title clarify parameter handling at the fork boundary Update EIP-7691: clarify parameter handling at the fork boundary Jan 16, 2025
@ralexstokes ralexstokes force-pushed the 7691/clarify-fork-handling branch from b99da2d to 5de0e72 Compare January 16, 2025 19:54
Copy link

The commit 5de0e72 (as a parent of 564b1ae) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 16, 2025
Copy link
Contributor

@nerolation nerolation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eth-bot eth-bot enabled auto-merge (squash) January 16, 2025 20:42
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot
eth-bot previously approved these changes Jan 20, 2025
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled January 22, 2025 17:35

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) January 22, 2025 17:36
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit d64f4c3 into ethereum:master Jan 22, 2025
10 of 18 checks passed
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jan 22, 2025
@ralexstokes ralexstokes deleted the 7691/clarify-fork-handling branch January 22, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants