-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Block-level Warming #9246
Conversation
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this EIP! 😄
I think in general the idea here is that we only charge the cold gas cost once, and this is used to reflect when we pull this storage from disk. If that is the case, then I also propose we remove the logic from 2929 which reverts the journal of warm slots in case a sub-call reverts. This would make the implementation of 2929 for this fork likely much easier (since the revert mechanism does not have to be coded) and we thus now have that cold load costs for an account/slot are at most only charged once per blob.
The commit df49e2c (as a parent of 0c66ba4) contains errors. |
how different is this from https://eips.ethereum.org/EIPS/eip-3584 ? if not much can we revive the same EIP? |
I think they are different enough to keep separate. 3584 is more to share the access list mechanism over the block while this EIP is about doing this without using access lists though a first-access-pays mechanism + no arguments in the header. I can see a realistic world with both of those EIPs being shipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
This EIP proposes to keep accessed addresses and storage keys warm over the duration of a block.