Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5792: Propose changes to EIP-5792 #8826

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
+113 −82
Open

Update EIP-5792: Propose changes to EIP-5792 #8826

Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
40d79c7
Propose changes to EIP-5792
forshtat Aug 25, 2024
a97f3a2
Update EIPS/eip-5792.md
forshtat Aug 26, 2024
d14ce17
Rename status response field from 'capabilitiesData' to 'capabilities…
forshtat Sep 4, 2024
0ecea7b
Change batch identifier size from 32 bytes to 64 bytes
forshtat Sep 4, 2024
b364b92
Rename 'batchId' to 'callsId'
forshtat Nov 21, 2024
84c6d4d
update 5792 with more specifics re capabilities
lukasrosario Dec 5, 2024
2c3d75e
update atomicBatch
lukasrosario Dec 5, 2024
b769acc
formatting
lukasrosario Dec 5, 2024
c837526
more formatting
lukasrosario Dec 5, 2024
b8e75d5
Merge pull request #11 from lukasrosario/lukas/update-capabilities-sp…
forshtat Dec 6, 2024
b337a12
Add
forshtat Dec 6, 2024
e10da9a
update status codes
lukasrosario Jan 8, 2025
0a705ca
lint
lukasrosario Jan 8, 2025
41b1024
push
lukasrosario Jan 8, 2025
4253f62
Merge branch 'eip-5792-proposal' into lukas/add-statuses
lukasrosario Jan 8, 2025
cfe2529
add note
lukasrosario Jan 8, 2025
c6f2700
lint
lukasrosario Jan 8, 2025
ad36c64
address comments
lukasrosario Jan 10, 2025
746cc8c
add capabilities to response
lukasrosario Jan 11, 2025
15e27af
Merge pull request #12 from lukasrosario/lukas/add-statuses
forshtat Jan 13, 2025
00b6242
switch error status codes
lukasrosario Jan 14, 2025
2ef7d48
Merge pull request #13 from lukasrosario/lukas/switch-status-codes
forshtat Jan 15, 2025
baeeb02
Remove 'atomicBatch' capability; clean up ambiguity; add 'wallet_show…
forshtat Jan 16, 2025
20ccae2
Rephrase mixing `optional` and MUST in one sentence
forshtat Jan 16, 2025
f88f6ed
Remove rationale for `from` and `chainId` being top-level
forshtat Jan 16, 2025
b89b616
Make 'status' field a 'number'
forshtat Jan 16, 2025
6bfea5b
Rephrase the optional capability example
forshtat Jan 16, 2025
b9c213a
Rephrase stopping after error rule
forshtat Jan 16, 2025
2995ac0
Rephrase call batch status within session rule
forshtat Jan 16, 2025
7516f52
Grammar
forshtat Jan 16, 2025
80fbeb4
status type fix
lukasrosario Jan 16, 2025
5ff15e7
Merge pull request #14 from lukasrosario/lukas/status-example-fix
forshtat Jan 16, 2025
54a6243
Elaborate "atomic unit in a single transaction"
forshtat Jan 16, 2025
0de3f96
Move "unless" part of the wallet rules to the top of the list
forshtat Jan 16, 2025
8532ab0
make 'from' optional
lukasrosario Jan 17, 2025
e457851
move status codes, add clarification on 'from' param
lukasrosario Jan 17, 2025
04d4525
Update eip-5792.md
forshtat Jan 17, 2025
0b506c0
Merge pull request #15 from lukasrosario/lukas/optional-from
forshtat Jan 17, 2025
9d6d4e9
Explicitly require '0x' and ban leading zeroes
forshtat Jan 21, 2025
534c81b
Define the Capability type
forshtat Jan 21, 2025
77f32cc
Replace "session" with a 24 hour window as a rule is "SHOULD" anyways
forshtat Jan 21, 2025
a3d61d3
Reword the 'wallet_getCallsStatus' receipt(s) rules
forshtat Jan 22, 2025
7701a64
Introduce a 600 status category for partial on-chain revert
forshtat Jan 22, 2025
1be7d7d
Explicitly return 4100 Unauthorized error in 'wallet_getCapabilities'
forshtat Jan 22, 2025
a0ff4d7
Update eip-5792.md: Add myself as author
SamWilsn Jan 22, 2025
30c907f
Merge pull request #18 from SamWilsn/patch-1
forshtat Jan 22, 2025
08b645c
remove security consideration section
lukasrosario Jan 22, 2025
9a88ef6
add a security consideration
lukasrosario Jan 22, 2025
5f5d026
better
lukasrosario Jan 22, 2025
379a2f3
Merge pull request #19 from lukasrosario/lukas/atomicity-feedback
forshtat Jan 22, 2025
97175a3
add optional id
lukasrosario Jan 27, 2025
3f37aaa
feedback
lukasrosario Jan 29, 2025
ffe443c
change response capability interface
lukasrosario Jan 29, 2025
10f6d85
Merge pull request #20 from lukasrosario/lukas/optional-id
forshtat Jan 29, 2025
ca8dcc2
feedback
lukasrosario Feb 3, 2025
2dcee4d
Merge pull request #21 from lukasrosario/feedback
forshtat Feb 3, 2025
ddf53b1
Add 'version' to the 'wallet_getCallsStatus' return value object
forshtat Feb 12, 2025
e8e1400
Update eip-5792.md
forshtat Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading