Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release flow migration to CircleCI [2/N] #318

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

janjakubnanista
Copy link
Collaborator

@janjakubnanista janjakubnanista commented Jan 14, 2025

Description

Continuing the migration from GHA to CircleCI, the release flow is next.

  • Added the release workflow that runs on tag push
    • There is a small existing issue where a tag referring to a commit that's not on main will still trigger this pipeline. Will be addressed in a separate PR since it's not a regression
  • Updated version of the base image since the python version in v0.35.0 was causing issues with utils/get-github-access-token command (see here)
  • Removed the install-foundry command since the new image contains a compatible foundry version already
  • Removed the TAP_REPO_GITHUB_TOKEN environment variable from .goreleaser.yaml. The GITHUB_TOKEN produced from utils/get-github-access-token has write permissions to both supersim and homebrew-tap so we no longer need two tokens

Once this change is merged, the github release workflow should be disabled to prevent race conditions and duplicate releases. Once the change is stable the github workflow will be deleted.

Tests

The workflow has been tested on a dummy playground repository, see here

Copy link

cloudflare-workers-and-pages bot commented Jan 14, 2025

Deploying supersim with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0aba092
Status: ✅  Deploy successful!
Preview URL: https://338f2182.supersim.pages.dev
Branch Preview URL: https://jan-circleci--002.supersim.pages.dev

View logs

@janjakubnanista janjakubnanista self-assigned this Jan 14, 2025
@janjakubnanista janjakubnanista changed the title chore: Stub of the release flow migration to CircleCI chore: Stub of the release flow migration to CircleCI [2/N] Jan 14, 2025
@janjakubnanista janjakubnanista marked this pull request as ready for review January 15, 2025 19:39
@janjakubnanista janjakubnanista requested a review from a team as a code owner January 15, 2025 19:39
@janjakubnanista janjakubnanista changed the title chore: Stub of the release flow migration to CircleCI [2/N] chore: Release flow migration to CircleCI [2/N] Jan 16, 2025
Copy link
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Are you going to be disabling the github release action?

@janjakubnanista
Copy link
Collaborator Author

Hey @hamdiallam! Yea I'll disable it

@janjakubnanista janjakubnanista merged commit 4cec4b9 into main Jan 16, 2025
7 of 10 checks passed
@janjakubnanista janjakubnanista deleted the jan/circleci--002 branch January 16, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants