-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Release flow migration to CircleCI [2/N] #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying supersim with Cloudflare Pages
|
janjakubnanista
changed the title
chore: Stub of the release flow migration to CircleCI
chore: Stub of the release flow migration to CircleCI [2/N]
Jan 14, 2025
janjakubnanista
force-pushed
the
jan/circleci--002
branch
from
January 15, 2025 17:36
f92ab97
to
597feb8
Compare
janjakubnanista
force-pushed
the
jan/circleci--002
branch
from
January 15, 2025 19:31
3fe0d5c
to
0aba092
Compare
janjakubnanista
changed the title
chore: Stub of the release flow migration to CircleCI [2/N]
chore: Release flow migration to CircleCI [2/N]
Jan 16, 2025
hamdiallam
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Are you going to be disabling the github release action?
Hey @hamdiallam! Yea I'll disable it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing the migration from GHA to CircleCI, the release flow is next.
release
workflow that runs on tag pushmain
will still trigger this pipeline. Will be addressed in a separate PR since it's not a regressionv0.35.0
was causing issues withutils/get-github-access-token
command (see here)install-foundry
command since the new image contains a compatiblefoundry
version alreadyTAP_REPO_GITHUB_TOKEN
environment variable from.goreleaser.yaml
. TheGITHUB_TOKEN
produced fromutils/get-github-access-token
has write permissions to bothsupersim
andhomebrew-tap
so we no longer need two tokensOnce this change is merged, the github release workflow should be disabled to prevent race conditions and duplicate releases. Once the change is stable the github workflow will be deleted.
Tests
The workflow has been tested on a dummy playground repository, see here