feat: update spec to use v4 payload methods for isthmus #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyer9
requested review from
protolambda,
sebastianst and
ajsutton
as code owners
danyalprout
reviewed
Jan 18, 2025
emhane
approved these changes
Jan 18, 2025
emhane
added
H-isthmus
refcell
reviewed
Jan 21, 2025
| [`engine_getPayloadV4`][engine_getPayloadV4] retrieves a payload by ID, prepared by `engine_forkchoiceUpdatedV3` | ||
| when called with `payloadAttributes`. | ||
| `engine_getPayloadV4` **must only be called with Isthmus payload.** | ||
|
|
There was a problem hiding this comment.
Just need to remove this line to make ci pass.
Suggested change
meyer9
force-pushed
the
meyer9/new-payload-v4-isthmus
branch
from
a6ba30f to
40562fa
Compare
danyalprout
approved these changes
Jan 21, 2025
tynes
approved these changes
Jan 22, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
executionRequestsmust be an empty arrayTests
Additional context
This PR doesn't revert the withdrawal root changes, so there are still some outdated docs here.
Metadata
Fixes #506.