Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isthmus: operator fee #382
base: main
Are you sure you want to change the base?
Isthmus: operator fee #382
Changes from 59 commits
f4ef24d
d2f40a0
7ddbce3
2e12898
1407fa9
50c22ec
78cb4cb
6a78e21
fb53c85
b56048a
7c90f2b
f4e27b3
1526415
7085d98
148230b
fbf8dfb
48a25af
98fdb84
ead7704
1ade65a
4673839
b945faf
2f73dc2
43c5ea9
2efe231
816cc6c
a8e094e
1314351
63d1760
76fa61a
3afa960
f45744f
2a64355
2f0187f
1625dab
bc293f2
ff1aa7f
317ac76
bbb9e05
4c3eaca
cfdc6fc
3db2793
e2af323
b88dcf8
dcf4bdd
6ad2938
3d9f967
3c99591
2bf6246
4e0f724
9ab37f9
c7efd31
6c57838
1aa27f4
219e72c
762dbf7
99c9f4d
18c8127
54ea6a4
6512664
c7cffb1
0accd5f
91a129c
e3f4913
9acbf42
f205eae
ba1745e
74d388f
e70bc27
e64de24
92b2d4b
3d6b257
31500e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we are not combining this with L2 standard genesis, we are going to need to rethink how we go about configuring the system. How does the existing solidity implementation work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there was a bad merge in this file, I will have a look.
Currently I added a new method
setOperatorFeeScalars(uint32, uint64)
toSystemConfig
. But reading the same file in the main branch, I see a section about Fee Vault Config, so I guess I should conform with that and add afunction setOperatoreFeeVaultConfig(address,uint256,WithdrawalNetwork)
method. Is it what you have in mind?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, I saw the Fee Vault Config section is part of L2 standard genesis, so I won't need to conform with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is underspecified. What are the definitions of the network upgrade transactions? The ecotone specs contain examples of this. This is important because the derivation pipeline has to deterministically create these transactions, ie who is the
from
, what is theto
, what is thedata
? For the contract deployments, we need finalized bytecode, which will need to come from a releaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you send a link to one of the ecotone specs that contains an example of the network upgrade transaction definitions?
I don't see a clear format in the derivation spec: https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/ecotone/derivation.md#ecotone-blob-retrieval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they are in the wrong place: https://github.com/ethereum-optimism/specs/blob/87e13cba8f34a68858a334fc2587041b712facfa/specs/protocol/derivation.md#network-upgrade-automation-transactions
I can move them to the correct place