Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update spec to use v4 payload methods for isthmus #525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: update spec to use v4 payload methods for isthmus #525

wants to merge 1 commit into from

Conversation

meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 17, 2025

Description

Tests

Additional context

This PR doesn't revert the withdrawal root changes, so there are still some outdated docs here.

Metadata

Fixes #506.

danyalprout
danyalprout reviewed Jan 18, 2025
View reviewed changes
specs/protocol/derivation.md

The current version of `op-node` uses the `v3` Engine API RPC methods as well as `engine_newPayloadV2`, due to
`engine_newPayloadV3` only supporting Ecotone execution payloads. Both `engine_forkchoiceUpdatedV3` and
The current version of `op-node` uses the `v4` Engine API RPC methods as well as `engine_newPayloadV3`, due to
Copy link
Contributor

@danyalprout danyalprout Jan 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll use both V2 and V3 for pre-Ecotone blocks.

@emhane emhane requested review from refcell and tynes January 18, 2025 12:36
emhane
emhane approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is super helpful, thank you ser. if you could also open an issue for reverting the withdrawal root changes that would be appreciated.

@emhane emhane added H-isthmus Hardfork: change is planned for Isthmus upgrade U-node Upgrade: involving changes to node component (cl, el, etc.) H-pectra Hardfork: change planned for Pectra (L1) upgrade A-consensus Area: consensus layer A-execution Area: execution layer U-noop Upgrade: L1 feature not used on L2 requires noop spec to disable labels Jan 18, 2025
@emhane emhane mentioned this pull request Jan 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyalprout danyalprout danyalprout left review comments

@emhane emhane emhane approved these changes

@protolambda protolambda Awaiting requested review from protolambda protolambda is a code owner

@sebastianst sebastianst Awaiting requested review from sebastianst sebastianst is a code owner

@ajsutton ajsutton Awaiting requested review from ajsutton ajsutton is a code owner

@refcell refcell Awaiting requested review from refcell

@tynes tynes Awaiting requested review from tynes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-consensus Area: consensus layer A-execution Area: execution layer H-isthmus Hardfork: change is planned for Isthmus upgrade H-pectra Hardfork: change planned for Pectra (L1) upgrade U-node Upgrade: involving changes to node component (cl, el, etc.) U-noop Upgrade: L1 feature not used on L2 requires noop spec to disable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EIP-7685: General Purpose Execution Layer Requests
3 participants
@meyer9 @danyalprout @emhane