Feat: Add sll/srl/sra/sllv/srlv/srav/jr/jalr/bne/beq mips test #12808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrapeBaBa
changed the title
GrapeBaBa
force-pushed
the
mips_remain
branch
from
1fc7d78 to
b79c6eb
Compare
GrapeBaBa
changed the title
|
/ci authorize b79c6eb |
|
Why failed CI |
mbaxter
approved these changes
Nov 12, 2024
|
/ci authorize ca375ce |
mbaxter
reviewed
Nov 13, 2024
GrapeBaBa
requested review from
clabby,
Inphi,
mslipper,
tynes and
protolambda
Signed-off-by: Chen Kai <[email protected]>
Signed-off-by: Chen Kai <[email protected]>
Co-authored-by: mbaxter <[email protected]>
GrapeBaBa
force-pushed
the
mips_remain
branch
from
b19f495 to
90c0514
Compare
Signed-off-by: Chen Kai <[email protected]>
|
/ci authorize 780055d |
Merged
via the queue into
ethereum-optimism:develop
with commit Nov 13, 2024
012398c
49 checks passed
boyuan-chen
pushed a commit
to bobanetwork/boba
that referenced
this pull request
Nov 14, 2024
…eum-optimism#12808) * feat:add bne test Signed-off-by: Chen Kai <[email protected]> * feat:Add sll/srl/sra/sllv/srlv/srav/jr/jalr/beq/bne mips test Signed-off-by: Chen Kai <[email protected]> * Apply suggestions from code review Co-authored-by: mbaxter <[email protected]> * fix:add code review suggestion Signed-off-by: Chen Kai <[email protected]> --------- Signed-off-by: Chen Kai <[email protected]> Co-authored-by: mbaxter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add remaining mips instr tests
Tests
Additional context
Metadata