MT Cannon: add mips movf/movt tests #12392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Kai <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12392 +/- ##
===========================================
+ Coverage 64.32% 64.39% +0.06%
===========================================
Files 52 52
Lines 4348 4356 +8
===========================================
+ Hits 2797 2805 +8
- Misses 1376 1377 +1
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mbaxter
approved these changes
Oct 10, 2024
Signed-off-by: Chen Kai <[email protected]>
GrapeBaBa
commented
Oct 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 11, 2024
a5d0e30
58 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* feat:add movf/movt tests Signed-off-by: Chen Kai <[email protected]> * fix:fix code review nit Signed-off-by: Chen Kai <[email protected]> --------- Signed-off-by: Chen Kai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add mips movf/movt tests
Tests
Additional context
Metadata