Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: do not hash header if header is still changing #462

Draft
wants to merge 1 commit into
base: optimism
Choose a base branch
from
+5 −1
Draft

core: do not hash header if header is still changing #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/state_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,11 @@ func ApplyTransactionExtended(config *params.ChainConfig, bc ChainContext, autho
blockContext := NewEVMBlockContext(header, bc, author, config, statedb)
txContext := NewEVMTxContext(msg)
vmenv := vm.NewEVM(blockContext, txContext, statedb, config, cfg)
return ApplyTransactionWithEVM(msg, config, gp, statedb, header.Number, header.Hash(), tx, usedGas, vmenv)
blockHash := common.Hash{}
if header.Root != (common.Hash{}) { // if the header is sealed, then hydrate the receipt with it. If not, then blockhash is still changing, not worth computing.
blockHash = header.Hash()
}
return ApplyTransactionWithEVM(msg, config, gp, statedb, header.Number, blockHash, tx, usedGas, vmenv)
}

// ProcessBeaconBlockRoot applies the EIP-4788 system call to the beacon block root
Expand Down
Loading