Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for an AWS KMS provider #122

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+573 −9
Open

Adding support for an AWS KMS provider #122

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df7cec5
feat(op-signer): add KeyProvider enum for cloud provider selection
ddaws Jan 15, 2025
aac0d7a
refactor(op-signer): move KeyProvider to top-level config
ddaws Jan 15, 2025
6d9eee4
feat(op-signer): add provider factory for signature providers
ddaws Jan 15, 2025
0badbd2
feat(op-signer): add AWS KMS signature provider
ddaws Jan 15, 2025
b78337e
chore(deps): add AWS SDK dependencies
ddaws Jan 15, 2025
90e8f03
chore(lint): fixed spelling
ddaws Jan 15, 2025
51911ee
feat(op-signer): add DER encoding utilities for secp256k1 keys
ddaws Jan 15, 2025
6564016
feat(op-signer): add signature format conversion utilities
ddaws Jan 15, 2025
7d63efc
test(op-signer): add AWS KMS signature provider tests
ddaws Jan 15, 2025
410a131
fix(op-signer): use %w verb for error wrapping in DER conversion
ddaws Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(deps): add AWS SDK dependencies 
Add AWS SDK dependencies required for AWS KMS implementation:
- github.com/aws/aws-sdk-go-v2/config
- github.com/aws/aws-sdk-go-v2 (indirect)

These dependencies are needed for the AWS KMS signature provider functionality.
@ddaws
ddaws committed Jan 15, 2025
commit b78337e9e942bd2c3d02838a5147fcece66cdbae
2 changes: 1 addition & 1 deletion op-signer/go.mod
View file
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ go 1.22.0

require (
cloud.google.com/go/kms v1.12.1
github.com/aws/aws-sdk-go-v2/config v1.28.11
github.com/ethereum-optimism/optimism v0.0.0-20241213111354-8bf7ff60f34a
github.com/ethereum/go-ethereum v1.14.11
github.com/golang/mock v1.6.0
@@ -19,7 +20,6 @@ require (

require (
github.com/aws/aws-sdk-go-v2 v1.32.8 // indirect
github.com/aws/aws-sdk-go-v2/config v1.28.11 // indirect
github.com/aws/aws-sdk-go-v2/credentials v1.17.52 // indirect
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.23 // indirect
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.27 // indirect