-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common.Hash in VMState - Update Monorepo submodule to 457f33f #68
Conversation
I think we'll need to update |
@ajsutton I naively guessed it works.. but it seems something's broken in the CI. Let me check what should I fix more, including op-challenger. |
My guess is we'll have to change https://github.com/ethereum-optimism/optimism/blob/8447d1653a32d2210d8aa2f12c43889de4c3b1c7/op-challenger/game/fault/trace/asterisc/state.go#L21 to a |
213ea5a
to
5e152a8
Compare
@ajsutton right. I'll update it in the monorepo and check via e2e to confirm everything works. |
5e152a8
to
75b804c
Compare
ba958fd
to
3e3e8c2
Compare
Update: opened a monorepo PR: ethereum-optimism/optimism#10967, and added some details in the PR description. |
656659c
to
311b533
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
=========================================
Coverage ? 72.25%
=========================================
Files ? 16
Lines ? 2725
Branches ? 0
=========================================
Hits ? 1969
Misses ? 671
Partials ? 85 ☔ View full report in Codecov by Sentry. |
Description
Use
common.Hash
type in VMState instead of bytes array. it would improve readability of output files and we don't need to make proof file to get prestate.Updated:
rvsol
and monorepo contracts, I have moved library files inrvsol/scripts/lib
directory, and changedforge-std/
to@forge-std/
.