Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: ci: asterisc fault proof tests #51

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented Apr 15, 2024

Description

This mirrors monorepo's fault proof op-e2e-cannon-test for asterisc. The tests can be run locally or at CI(see https://app.circleci.com/pipelines/github/ethereum-optimism/asterisc/201/workflows/4a56b4ac-f95f-401f-8cb9-1de8733b12a0/jobs/708?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary that all tests are passing!).

Guidelines for running e2e locally is added.

monorepo version pinned at tip's monorepo fork at ethereum-optimism/optimism#10214. When this is merged, will repin to upstream monorepo. Rebased.

Tests

Mirrored Upstream tests.

These two tests are not needed to check asterisc functionality.

Added output_asterisc_test.go by mirroring output_cannon_test.go.

@pcw109550 pcw109550 force-pushed the tip/pcw109550/devnet-alloc-after-asterisc-deployment branch from 1b89878 to 750cd6f Compare April 17, 2024 02:55
@pcw109550 pcw109550 force-pushed the tip/pcw109550/op-e2e-asterisc branch from 7549b9d to eed2d41 Compare April 17, 2024 03:33
@pcw109550 pcw109550 changed the base branch from tip/pcw109550/devnet-alloc-after-asterisc-deployment to master April 17, 2024 21:35
@pcw109550 pcw109550 force-pushed the tip/pcw109550/op-e2e-asterisc branch 2 times, most recently from b065562 to 9b6304d Compare April 18, 2024 22:11
@pcw109550 pcw109550 force-pushed the tip/pcw109550/op-e2e-asterisc branch from bd542f7 to 8c171cd Compare April 19, 2024 05:31
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.39%. Comparing base (7f7893e) to head (b478d9c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   70.39%   70.39%           
=======================================
  Files          19       19           
  Lines        2810     2810           
=======================================
  Hits         1978     1978           
  Misses        743      743           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pcw109550 pcw109550 changed the base branch from master to tip/pcw109550/optimism-d2263b1 April 22, 2024 20:48
@pcw109550 pcw109550 force-pushed the tip/pcw109550/op-e2e-asterisc branch 3 times, most recently from 953e6e9 to 3f6b347 Compare April 22, 2024 21:42
@pcw109550 pcw109550 changed the base branch from tip/pcw109550/optimism-d2263b1 to master April 22, 2024 21:43
@pcw109550 pcw109550 force-pushed the tip/pcw109550/op-e2e-asterisc branch from 3f6b347 to 5b6d7ce Compare April 22, 2024 21:48
@pcw109550 pcw109550 changed the title op-e2e: asterisc op-e2e: ci: asterisc fault proof tests Apr 22, 2024
@pcw109550 pcw109550 marked this pull request as ready for review April 22, 2024 22:35
@pcw109550 pcw109550 requested review from ImTei, Inphi and clabby April 22, 2024 22:35
Makefile Outdated Show resolved Hide resolved
@pcw109550 pcw109550 force-pushed the tip/pcw109550/op-e2e-asterisc branch from 27365ef to c05d05c Compare April 23, 2024 22:00
@pcw109550
Copy link
Contributor Author

pcw109550 commented Apr 23, 2024

Rebasing the monorepo breaks some tests. Will fix and reopen.

@pcw109550 pcw109550 marked this pull request as draft April 23, 2024 22:56
@pcw109550 pcw109550 marked this pull request as ready for review April 23, 2024 23:02
@pcw109550 pcw109550 mentioned this pull request Apr 29, 2024
Copy link
Collaborator

@ImTei ImTei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a simple suggestion about documentation. �Everything else looks good to me!

@pcw109550 pcw109550 force-pushed the tip/pcw109550/op-e2e-asterisc branch from c05d05c to b478d9c Compare April 29, 2024 23:07
@pcw109550 pcw109550 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into master with commit 0bbe1c1 Apr 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants