Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix != 0 check in rvsol #113

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix != 0 check in rvsol #113

merged 2 commits into from
Jan 9, 2025

Conversation

mininny
Copy link
Collaborator

@mininny mininny commented Jan 6, 2025

Description

Using bitwise not on a 0 padded uint256 value results in the value being uint256.max when it should be 1.

Use eq(x,0) to check for not instead.

@mininny mininny force-pushed the feature/mininny/audit-27 branch from 9724720 to ed1a0ce Compare January 6, 2025 09:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.89%. Comparing base (8ff9318) to head (e5a5842).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          27       27           
  Lines        4091     4091           
=======================================
  Hits         2532     2532           
  Misses       1427     1427           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rvsol/src/RISCV.sol Outdated Show resolved Hide resolved
@mininny mininny added the Audit finding grouping for our audit findings label Jan 7, 2025
@mininny mininny requested a review from refcell January 7, 2025 05:02
@mininny mininny added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit bf4e465 Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audit finding grouping for our audit findings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants