Add function selector check for slow vm #108
Merged
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Go slow implementation is intended to mirror the Solidity implementation. For this, it takes the calldata as input.
However, the slow implementation lacks a check that is abstracted in the Solidity implementation: the function selector.
As the function selector is not checked, calldata with incorrect selector will be executable on the slow implementation but will revert on the Solidity smart contract.
Ensure on the slow implementation that the first 4 bytes of calldata correspond to the correct function selector.