Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicative constants in state.go and fix mismatched page size #104

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mininny
Copy link
Collaborator

@mininny mininny commented Dec 13, 2024

There are two different constant definition in state.go and memory.go which are confusing and actually mis-used. This PR removes the constant definition in state.go and fix the call in memory.go/GetUnaligned.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.89%. Comparing base (8ff9318) to head (056f92e).

Files with missing lines Patch % Lines
rvgo/fast/memory.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          27       27           
  Lines        4091     4091           
=======================================
  Hits         2532     2532           
  Misses       1427     1427           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlocksOnAChain BlocksOnAChain added the Audit finding grouping for our audit findings label Dec 16, 2024
@mininny mininny requested a review from refcell January 8, 2025 21:35
@mininny mininny added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit 5e1a9ea Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audit finding grouping for our audit findings
Development

Successfully merging this pull request may close these issues.

4 participants