Skip to content

Commit

Permalink
update build.yml
Browse files Browse the repository at this point in the history
- call depcheck in ci
- update checkout, cache [deprecated] actions
  • Loading branch information
drortirosh committed Feb 4, 2025
1 parent aa5b29a commit d96da79
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ jobs:
- uses: actions/setup-node@v1
with:
node-version: '22'
- uses: actions/checkout@v1
- uses: actions/cache@v2
- uses: actions/checkout@v4
with:
show-progress: false
- uses: actions/cache@v4
with:
path: node_modules
key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}
Expand All @@ -53,12 +55,15 @@ jobs:
- uses: actions/setup-node@v1
with:
node-version: '22'
- uses: actions/checkout@v1
- uses: actions/cache@v2
- uses: actions/checkout@v4
with:
show-progress: false
- uses: actions/cache@v4
with:
path: node_modules
key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}
- run: yarn install
- run: yarn depcheck
- run: yarn lint

coverage:
Expand Down
5 changes: 4 additions & 1 deletion src/Create2Factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ export class Create2Factory {
to: Create2Factory.factoryDeployer,
value: BigNumber.from(Create2Factory.factoryDeploymentFee)
})
await this.provider.sendTransaction(Create2Factory.factoryTx)
// (with latest geth, can't tx.wait on the very first tx: reverts with "transaction indexing is in progress")
await new Promise(resolve => setTimeout(resolve, 100))

await this.provider.sendTransaction(Create2Factory.factoryTx).then(async tx => tx.wait())
if (!await this._isFactoryDeployed()) {
throw new Error('fatal: failed to deploy deterministic deployer')
}
Expand Down

0 comments on commit d96da79

Please sign in to comment.