Add feature gates doc for etcd #941
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangli113 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @gangli113. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
gangli113
force-pushed
the
addFeatureGatesDoc
branch
2 times, most recently
from
4beeaa5 to
c7d5a67
Compare
gangli113
force-pushed
the
addFeatureGatesDoc
branch
from
c7d5a67 to
1002b6b
Compare
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
gangli113
force-pushed
the
addFeatureGatesDoc
branch
from
eeca4bd to
1bb29ed
Compare
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
gangli113
force-pushed
the
addFeatureGatesDoc
branch
from
368da16 to
9c18cec
Compare
|
/lgtm Thanks @gangli113 ! /cc @serathius @ahrtr |
|
/ok-to-test |
|
@gangli113: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| A *General Availability* (GA) feature is also referred to as a *stable* feature. It means: | ||
|
|
||
| * The feature is always enabled; you cannot disable it. | ||
| * The corresponding feature gate is no longer needed. | ||
| * Stable versions of features will appear in released software for many subsequent versions. |
There was a problem hiding this comment.
Can we be clearer on the GA features?
If users configure a non-exist feature gate, an error will be raised and etcd may even fail to get started. For a GA feature, users can still configure it, we might just raise a warning but etcd can still get started correctly. We just ignore users' configuration, and always enable GA feature. Is this correct?
#940
This change copied most content from https://github.com/kubernetes/website/edit/main/content/en/docs/reference/command-line-tools-reference/feature-gates/index.md.