Align Dockerfile builder image

[jmhbnz]

Ensure golang patch version is specified.
Base of Debian Bookworm in line with other etcd projects.

Addresses: #37 (comment)

cc @ahrtr

[jmhbnz]

Test failure addressed by kubernetes/test-infra#34146

[jmhbnz]

/retest

[ivanvc]

Follow up on test failure at PR: kubernetes/test-infra#34147

[ivanvc]

/retest

[ahrtr]

/test pull-etcd-operator-test-e2e

[hakman]

LGTM

[hakman]

@jmhbnz I am curious, why do we set toolchain version in the go.mod file?

[ahrtr]

@jmhbnz I am curious, why do we set toolchain version in the go.mod file?

It should be a best practice. Pinning to a specific/consistent go version ensures we have the same go version in test and production environment, also ensure we always build the binary/image with a safe (usually the latest patch version) go version.

[hakman]

@jmhbnz I am curious, why do we set toolchain version in the go.mod file?

It should be a best practice. Pinning to a specific/consistent go version ensures we have the same go version in test and production environment, also ensure we always build the binary/image with a safe (usually the latest patch version) go version.

I was a little confused on what Go version GHA uses from the go.mod file, either toolchain go1.23.4 or go 1.23.0.
Maybe we need to set the Go version to the toolchain version.

2025-01-15T09:52:28.3490983Z Adding to the cache ...
2025-01-15T09:52:32.5799032Z Successfully cached go to /opt/hostedtoolcache/go/1.23.0/x64
2025-01-15T09:52:32.5800450Z Added go to the path
2025-01-15T09:52:32.5803586Z Successfully set up Go version 1.23.0
2025-01-15T09:52:36.6251957Z go: downloading go1.23.4 (linux/amd64)
2025-01-15T09:52:36.6408632Z [command]/opt/hostedtoolcache/go/1.23.0/x64/bin/go env GOMODCACHE
2025-01-15T09:52:36.6447123Z [command]/opt/hostedtoolcache/go/1.23.0/x64/bin/go env GOCACHE

[ahrtr]

I was a little confused on what Go version GHA uses from the go.mod file, either toolchain go1.23.4 or go 1.23.0.
Maybe we need to set the Go version to the toolchain version.

Good catch, we should follow the toolchain, just raised #41

[ahrtr]

Also I am thinking probably setting a tag 1.23.4-bookworm should be enough. There is no need to add a digest (SHA 256 value). I assume that the tag and digest is 1:1 mapping.

[hakman]

Also I am thinking probably setting a tag 1.23.4-bookworm should be enough. There is no need to add a digest (SHA 256 value). I assume that the tag and digest is 1:1 mapping.

It is not enough to use the tag, they regularly rebuild with newer bookworm base image.

[ahrtr]

LGTM

Thanks @jmhbnz

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivanvc]

/retest