Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependabot config for weekly updates #20

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

hakman
Copy link
Contributor

@hakman hakman commented Jan 7, 2025

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @hakman 🙏🏻

Comment on lines +10 to +21
schedule:
interval: "weekly"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we only bump direct dependencies.

Suggested change
schedule:
interval: "weekly"
schedule:
interval: "weekly"
allow:
- dependency-type: direct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the gomod section.

Comment on lines 17 to 24
groups:
k8s:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"
onsi:
patterns:
- "github.com/onsi/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused. Usually github-actions only focuses on .github/workflows; but "k8s.io/*", "sigs.k8s.io/*" and "github.com/onsi/*" are dependencies used in golang source code. Did I miss anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, moved to the gomod section.

Comment on lines +10 to +16
k8s:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"
onsi:
patterns:
- "github.com/onsi/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: for dependencies not included here, will they also be automatically bumped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, other dependencies will also be bumped. this just says to bump the group together if there are updates for multiple dependencies in the group.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, hakman, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,hakman,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 8c08cfa into etcd-io:main Jan 7, 2025
3 checks passed
@hakman hakman deleted the dependabot branch January 7, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants