-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dependabot config for weekly updates #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @hakman 🙏🏻
schedule: | ||
interval: "weekly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we only bump direct dependencies.
schedule: | |
interval: "weekly" | |
schedule: | |
interval: "weekly" | |
allow: | |
- dependency-type: direct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to the gomod
section.
.github/dependabot.yml
Outdated
groups: | ||
k8s: | ||
patterns: | ||
- "k8s.io/*" | ||
- "sigs.k8s.io/*" | ||
onsi: | ||
patterns: | ||
- "github.com/onsi/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little confused. Usually github-actions
only focuses on .github/workflows
; but "k8s.io/*"
, "sigs.k8s.io/*"
and "github.com/onsi/*"
are dependencies used in golang source code. Did I miss anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, moved to the gomod
section.
Signed-off-by: Ciprian Hacman <[email protected]>
k8s: | ||
patterns: | ||
- "k8s.io/*" | ||
- "sigs.k8s.io/*" | ||
onsi: | ||
patterns: | ||
- "github.com/onsi/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: for dependencies not included here, will they also be automatically bumped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, other dependencies will also be bumped. this just says to bump the group together if there are updates for multiple dependencies in the group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, hakman, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @jmhbnz @ahrtr