Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es_extended): allow users to change identifier type #1609

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Mycroft-Studios
Copy link
Contributor

Description

Allows users to change the identifier type that ESX uses


Motivation

Cfx not communicating changes


Implementation Details

  • Adds a convar: esx:identifier
  • steamlines Identifier usage
  • by default its license for compatibility

Usage Example

  • set esx:identifier license2
  • set esx:identifier steam

PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

Copy link
Contributor

@Kenshiin13 Kenshiin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about esx_multicharacter/server/main.lua?

Server.identifierType = ESX.GetConfig().Identifier or GetConvar("sv_lan", "") == "true" and "ip" or GetConvar("esx:identifier", "license")

@Kenshiin13 Kenshiin13 dismissed their stale review February 6, 2025 10:52

Nevermind, I'm blind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In-Development
Development

Successfully merging this pull request may close these issues.

2 participants