-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create markers.lua #1316
Create markers.lua #1316
Conversation
For ESX point system
Hi! @fusion-develops I like your solution and thanks for pr, but I don't know how happy Linden would be to use exactly the same name, so he's really referring to the ox_lib points function. If we don't look at this part because we are, say, just drawing inspiration from ox_lib, then we have name convention problems and probably the code doesn't work because it is used somewhere "inside" or "Inside" something in code. Have you tested this code? |
I've redone it and fixed the bugs and changed the name to Markers since that's what it would mostly be used for once approved I can use this to redo all the add-on resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test your code before open PR. Thanks a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you tested this refactored code? Probably the while loop will cause you to stop the rest of the code from running if there is any.
Closed due to inactivity. |
For ESX point system simpler version of ox libs