Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create markers.lua #1316

Closed
wants to merge 5 commits into from
Closed

Conversation

fusion-develops
Copy link

For ESX point system simpler version of ox libs

For ESX point system
@Gellipapa
Copy link
Contributor

Hi! @fusion-develops

I like your solution and thanks for pr, but I don't know how happy Linden would be to use exactly the same name, so he's really referring to the ox_lib points function.

If we don't look at this part because we are, say, just drawing inspiration from ox_lib, then we have name convention problems and probably the code doesn't work because it is used somewhere "inside" or "Inside" something in code.

Have you tested this code?

@fusion-develops
Copy link
Author

Hi! @fusion-develops

I like your solution and thanks for pr, but I don't know how happy Linden would be to use exactly the same name, so he's really referring to the ox_lib points function.

If we don't look at this part because we are, say, just drawing inspiration from ox_lib, then we have name convention problems and probably the code doesn't work because it is used somewhere "inside" or "Inside" something in code.

Have you tested this code?

I've redone it and fixed the bugs and changed the name to Markers since that's what it would mostly be used for once approved I can use this to redo all the add-on resources

Copy link
Contributor

@Gellipapa Gellipapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test your code before open PR. Thanks a lot.

[core]/es_extended/client/modules/points.lua Outdated Show resolved Hide resolved
[core]/es_extended/client/modules/points.lua Outdated Show resolved Hide resolved
[core]/es_extended/client/modules/points.lua Outdated Show resolved Hide resolved
@fusion-develops fusion-develops changed the title Create points.lua Create markers.lua Feb 29, 2024
Copy link
Contributor

@Gellipapa Gellipapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you tested this refactored code? Probably the while loop will cause you to stop the rest of the code from running if there is any.

@Gellipapa
Copy link
Contributor

Closed due to inactivity.

@Gellipapa Gellipapa closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants