Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(esx_core): spawning system, general code refactor #1306

Closed
wants to merge 8 commits into from

Conversation

Thekuca
Copy link
Contributor

@Thekuca Thekuca commented Jan 31, 2024

Replace spawnmanager player spawning system with esx player spawning system

@Thekuca Thekuca changed the title refactor(esx_core): change to esx spawn player system refactor(esx_core): esx spawn player system Jan 31, 2024
@Thekuca Thekuca requested a review from Gellipapa January 31, 2024 21:50
@Thekuca Thekuca assigned Thekuca and unassigned Thekuca Jan 31, 2024
@Thekuca
Copy link
Contributor Author

Thekuca commented Feb 1, 2024

Everything works, tested by me.

Copy link
Contributor Author

@Thekuca Thekuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is being tested currently

@Thekuca Thekuca changed the title refactor(esx_core): esx spawn player system refactor(esx_core): esx spawning system and general code refactoring Feb 1, 2024
@Gellipapa
Copy link
Contributor

@Thekuca Hi! Csoki callback is added in a separate PR because it's very risky that something will break and it's difficult to test.

So always open a PR for a context. Callbacks are now a separate topic so you need a separate PR for it. Thanks.

@Thekuca Thekuca changed the title refactor(esx_core): esx spawning system and general code refactoring refactor(esx_core): callbacks, spawning system, general code refactor Feb 1, 2024
@Thekuca Thekuca changed the title refactor(esx_core): callbacks, spawning system, general code refactor refactor(esx_core): spawning system, general code refactor Feb 2, 2024
@Thekuca
Copy link
Contributor Author

Thekuca commented Feb 8, 2024

@Gellipapa tested, works.

@Gellipapa
Copy link
Contributor

@Gellipapa tested, works.

Hi! Thanks i will test it soon.

@Thekuca Thekuca closed this Mar 1, 2024
@Thekuca Thekuca deleted the ref-thekuca branch September 15, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants