Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron up to 34 #2175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

DmitryAstafyev
Copy link
Collaborator

@DmitryAstafyev DmitryAstafyev commented Jan 24, 2025

Upgrades

  • electron
  • typescript
  • all others npm packages in holder, ts-bindings, platform

Important notes

electron-builder will not be updated for now (from 24.x to 25.x) as soon it comes with a linked package issue. Until developers give some response we would stay on 24.x. At least for now, the motivation of denying local dependencies (connected via link) isn't clean.

Workaround could be:

  • organization npm workspaces. What's probably the right direction in classic npm projects.
  • packing local dependencies with yarn/npm/pnpm pack and link packages. Good solution, also allows clean package from unused in production files. But yarn has issue with understanding relative paths. pnpm works well with relative paths.
  • using webpack for all internal npm modules (platform, ts-binding and probably holder). That's something what should be implemented in the future in anyway because it will: optimize JS code, correctly pull wasm and etc.)

In any way in the scope of upgrading electron it doesn't make sense to reorganize npm parts of solution and it should be done as a separated task. But some results of research could be useful.

using link using file using file with workspaces using pack (relative) using pack (absolute) webpack
yarn
build ok fail ok fail ok ok
electron build fail x ok x ok
dev run x x ok x ok
app run x x ok x ok
app work x x fail (no protocol wasm) x ok
bundle size x x 120 Mb x 114 Mb
pnpm
build ok ok fail ok
electron build fail ok x ok
dev run x fail x ok
app run x ok x ok
app work x ok x ok
bundle size x 140Mb (+20) x 114 Mb
  • builds are done with electron-builder 25.x and electron 34.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant