Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
holder
,ts-bindings
,platform
Important notes
electron-builder
will not be updated for now (from 24.x to 25.x) as soon it comes with a linked package issue. Until developers give some response we would stay on24.x
. At least for now, the motivation of denying local dependencies (connected via link) isn't clean.Workaround could be:
yarn/npm/pnpm pack
and link packages. Good solution, also allows clean package from unused in production files. Butyarn
has issue with understanding relative paths.pnpm
works well with relative paths.platform
,ts-binding
and probablyholder
). That's something what should be implemented in the future in anyway because it will: optimize JS code, correctly pull wasm and etc.)In any way in the scope of upgrading electron it doesn't make sense to reorganize npm parts of solution and it should be done as a separated task. But some results of research could be useful.
electron-builder 25.x
andelectron 34.x