webfilesbuilder update #670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @tctlrd this is great, thank you!! The only thing that I would ask you to change is to remove the process folder from this PR and add it to the .gitignore. I've tested everything else and it works fine. Also removing that folder is fine. Thanks! |
|
Oh, wait, I would also leave in the codebase the package-lock.json file, so we are sure to use the same dependencies. Thanks |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gulpfile.jsbuilder script and added more detailed log outputpackage.json(there is currently a warning on npm install "2 high severity vulnerabilities" over gulp-htmlmin's dep:kangax html-minifier REDoS vulnerability - https://github.com/advisories/GHSA-pfq8-rq6v-vf5m)I have not tested the resulting
src/webh/*.gz.hfiles on esp8266, since I am solely working with esp32 at this time. The output of this builder are running alright on the esp32 fork that I am working on /tctlrd/esp32-actl.