Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show loading title on webview #1429

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: show loading title on webview #1429

merged 1 commit into from
May 8, 2024

Conversation

justinenerio
Copy link
Contributor

Changes

show loading title on initial load

Related issues

Fixes #1428

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@justinenerio justinenerio requested a review from ookami-kb as a code owner May 7, 2024 02:53
@ookami-kb ookami-kb merged commit abf4eee into master May 8, 2024
8 checks passed
@ookami-kb ookami-kb deleted the webview-title-upd branch May 8, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

still display loading title even if we hardcode cash in and cash out title on the webview
2 participants
@justinenerio @ookami-kb