Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update share screen uis #1400

Merged
merged 5 commits into from
May 1, 2024
Merged

feat: update share screen uis #1400

merged 5 commits into from
May 1, 2024

Conversation

justinenerio
Copy link
Contributor

@justinenerio justinenerio commented May 1, 2024 •
edited
Loading

Changes

  • updates link and request share screens
  • update l10n

Related issues

Fixes #1394

Screenshots

Link

Simulator Screenshot - iPhone 15 Pro - 2024-05-01 at 23 00 54

Simulator Screenshot - iPhone 15 Pro - 2024-05-01 at 23 00 28

Request

Simulator Screenshot - iPhone 15 Pro - 2024-05-01 at 23 01 06

Simulator Screenshot - iPhone 15 Pro - 2024-05-01 at 23 02 49

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@justinenerio justinenerio marked this pull request as ready for review May 1, 2024 16:52
@justinenerio justinenerio requested a review from ookami-kb as a code owner May 1, 2024 16:52
@ookami-kb ookami-kb merged commit a8f9eba into master May 1, 2024
9 checks passed
@ookami-kb ookami-kb deleted the share-page-upd branch May 1, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update share screen for link payment and request payment
2 participants
@justinenerio @ookami-kb