Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update onboarding flow #1142

Merged
merged 7 commits into from
Nov 28, 2023
Merged

feat: update onboarding flow #1142

merged 7 commits into from
Nov 28, 2023

Conversation

justinenerio
Copy link
Contributor

@justinenerio justinenerio commented Nov 22, 2023

Changes

  • adds confirm recovery phrase in onboarding
  • backup phrase reminder launches same onboarding flow
  • remove confirm recovery phrase in Settings 'View recovery phrase'

Related issues

Fixes #1136

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbdc03b) 81.14% compared to head (86eb9c4) 81.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   81.14%   81.14%           
=======================================
  Files         183      183           
  Lines        3940     3940           
=======================================
  Hits         3197     3197           
  Misses        743      743           
Flag Coverage Δ
solana-beta 81.14% <ø> (?)
solana-stable 81.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinenerio justinenerio marked this pull request as ready for review November 26, 2023 11:10
@ookami-kb ookami-kb merged commit b9f0818 into master Nov 28, 2023
11 checks passed
@ookami-kb ookami-kb deleted the feat/onboarding-flow branch November 28, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this page should be part of the setup flow
2 participants