[VSC-1573] ensure build directories exist and resolve relative paths #1417
+86
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace forEach with Promise.all for proper async handling - Automatically create build directories using ensureDir - Convert relative paths to absolute using workspace folder as base - Refactor build config access for better readability
|
Download the artifacts for this pull request: |
brianignacio5
requested changes
Feb 12, 2025
| ? Uri.joinPath(workspaceFolder, buildConfig.sdkconfigFilePath) | ||
| .fsPath | ||
| : buildConfig?.sdkconfigFilePath, | ||
| sdkconfigDefaults: (await pathExists(buildConfig?.sdkconfigDefaults)) |
There was a problem hiding this comment.
Need to consider that sdkconfigDefaults is an array of files so this part of code would fail.
There was a problem hiding this comment.
Yes, I just noticed this was the thing that was giving me headaches. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where relative paths in project configurations were not being handled correctly and build directories were not being created automatically. The extension now properly resolves relative paths to absolute using the workspace folder as the base and ensures build directories exist before build commands are executed.
Fixes #1408
Type of change
Steps to test this pull request
{ "prod1": { "build": { "compileArgs": [], "ninjaArgs": [], "buildDirectoryPath": "build.prod1", "sdkconfigDefaults": [ "sdkconfig.prod_common", "sdkconfig.prod1" ], "sdkconfigFilePath": "" }, "env": {}, "flashBaudRate": "", "monitorBaudRate": "", "openOCD": { "debugLevel": 0, "configs": [], "args": [] }, "tasks": { "preBuild": "", "preFlash": "", "postBuild": "", "postFlash": "" } }, "prod2": { "build": { "compileArgs": [], "ninjaArgs": [], "buildDirectoryPath": "build.prod2", "sdkconfigDefaults": [ "sdkconfig.prod_common", "sdkconfig.prod2" ], "sdkconfigFilePath": "" }, "env": {}, "flashBaudRate": "", "monitorBaudRate": "", "openOCD": { "debugLevel": 0, "configs": [], "args": [] }, "tasks": { "preBuild": "", "preFlash": "", "postBuild": "", "postFlash": "" } } }Expected behaviour:
How has this been tested?
As described above
Test Configuration:
Checklist