Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(tinyusb): Added repo templates for issue and pull request #33

Merged
merged 1 commit into from
Nov 8, 2024
Merged

change(tinyusb): Added repo templates for issue and pull request #33

merged 1 commit into from
Nov 8, 2024

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Oct 31, 2024 •
edited
Loading

Describe the PR
Added the templates to:

  • Bug Report

and Pull Requests:

  • Update Component

Additional context
To simplify the PR workflow and keep all PRs in the same format.

@roma-jam roma-jam self-assigned this Oct 31, 2024
@roma-jam roma-jam marked this pull request as ready for review October 31, 2024 12:43
@roma-jam
Copy link
Collaborator Author

roma-jam commented Nov 1, 2024

@tore-espressif @peter-marcisovsky
Thanks for such a quick review, but I basically just copied files from the esp-usb, because I wanted to check it.
Now, while I still have concerns, I will request for the review when it will be ready.

@roma-jam roma-jam marked this pull request as draft November 1, 2024 09:02
@roma-jam roma-jam force-pushed the change/repo_templates branch 2 times, most recently from cdeac3d to 8b3e69f Compare November 1, 2024 12:01
@roma-jam roma-jam marked this pull request as ready for review November 1, 2024 12:01
@roma-jam
Copy link
Collaborator Author

roma-jam commented Nov 1, 2024

@tore-espressif @peter-marcisovsky
I have resolved the problem with Pull Request template (nested templates are not working ATM) and removed the issues templates, which I think we do not need.

PTAL again.

@roma-jam roma-jam force-pushed the change/repo_templates branch from 8b3e69f to e018912 Compare November 1, 2024 12:11
peter-marcisovsky
peter-marcisovsky reviewed Nov 1, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@roma-jam roma-jam force-pushed the change/repo_templates branch from e018912 to 6cc64fb Compare November 7, 2024 09:48
@roma-jam
Copy link
Collaborator Author

roma-jam commented Nov 7, 2024

@tore-espressif @peter-marcisovsky
Thanks for the reviewing.
I have updated the links to issues trackers (re-direct the user to upstream issues or to esp-usb issue tracker) and also added the issues optional field to idf_component.yml

PTAL.

peter-marcisovsky
peter-marcisovsky approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the changes. LGTM

@roma-jam roma-jam merged commit 7a9a901 into release/v0.17 Nov 8, 2024
7 checks passed
@roma-jam roma-jam deleted the change/repo_templates branch November 8, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tore-espressif tore-espressif tore-espressif approved these changes

@peter-marcisovsky peter-marcisovsky peter-marcisovsky approved these changes

Assignees

@roma-jam roma-jam

Labels
Prio Higher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roma-jam @tore-espressif @peter-marcisovsky