Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(websocket): add unregister event to websocket client #760

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat(websocket): add unregister event to websocket client #760

merged 1 commit into from
Feb 12, 2025

Conversation

glmfe
Copy link
Collaborator

@glmfe glmfe commented Feb 11, 2025 •
edited
Loading

Description

  • Add event unregister to websocket client
  • Minor: Updated code format

@glmfe glmfe marked this pull request as ready for review February 11, 2025 13:31
david-cermak
david-cermak approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the feature!

Optional suggestion: if we're using esp_websocket_register_events() in the example maybe we can also unregister it at the end.

@glmfe glmfe force-pushed the feat/add-ws-unregister branch from 2c665c4 to ce16050 Compare February 12, 2025 11:47
@david-cermak david-cermak merged commit f1a72ec into espressif:master Feb 12, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-cermak david-cermak david-cermak approved these changes

@euripedesrocha euripedesrocha euripedesrocha approved these changes

Assignees
No one assigned
Labels
websocket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glmfe @euripedesrocha @david-cermak