-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mdns): support allocating mDNS task from SPIRAM (IDFGH-14509) #746
base: master
Are you sure you want to change the base?
feat(mdns): support allocating mDNS task from SPIRAM (IDFGH-14509) #746
Conversation
064ea37
to
6ddcdae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general.
seems like |
0da7722
to
03b7edb
Compare
03b7edb
to
e75fa55
Compare
e75fa55
to
e33ba99
Compare
Hi, @david-cermak Might need your help: there are still two CI failed, one for target esp32, I can not reproduce this issue on my local env. And another one is for linux target, it seems that we do not support some FreeRTOS APIs for linux target. Do you have some suggestions for solving these? |
The tests actually flagged a pretry nasty bug while trying to delete the task from itself, including the stack size. But, here we don't have to be that strict IMO, fixing in #756 Also, should address this but since the unit tests pass, it's probably not too serious of a leak |
Description
This PR supports allocating mDNS task from PSRAM.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: